Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: disable flapping monitoringapi test #932

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Disables flapping monitoring API test until it is fixed. This isn't a critical test either.

category: test
ticket: #910

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #932 (6b19f4f) into main (0408b0f) will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   54.79%   54.35%   -0.44%     
==========================================
  Files         116      116              
  Lines       12577    12577              
==========================================
- Hits         6891     6836      -55     
- Misses       4699     4750      +51     
- Partials      987      991       +4     
Impacted Files Coverage Δ
core/qbft/qbft.go 71.67% <0.00%> (-10.31%) ⬇️
app/monitoringapi.go 67.52% <0.00%> (-8.55%) ⬇️
app/app.go 56.17% <0.00%> (+0.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 8, 2022
@obol-bulldozer obol-bulldozer bot merged commit 0e84079 into main Aug 8, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/disableflap branch August 8, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants