-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Implement #1
Comments
I don't see the PR |
Will do it, but I wanted to latest version of your main branch so that I can work off of that |
Ok, just commited my latest changes |
I don't have access to push to your repository |
Let me do that then |
Try now |
Verify and let me know. |
It does nothing: [0] DELETE /api/products/6089626dcc7322a7134fa879/reviews 201 323.964 ms - 28 Once I click, the error does not show, but it does not delete. The thing above is the response from the terminal in VSCODE |
Could you send a pic of the payload that's being sent on the delete request as well as the headers which are being sent |
Could you you send an screenshot of the payload, it should be the review data that we're sending from the frontend to the back |
Where do I find the payload? |
Screen.Recording.2021-04-28.at.11.25.41.AM.mov |
Does this help? @AstroProjection |
@AstroProjection Once we finish this, the next thing I want to integrate is Options. I created a issue about this in the proshop repo as well |
#3 - this PR should resolve the issues |
Yes it is working now |
Ok, I implemented coupons. I think this may be a stupid fix, but when I do multiplication by 0.3 which is supposed to be 30% gives me a bunch of numbers after it. You know for example 3.2993448 when I have .toFixed(2). Any fixes you can think of? |
You want me to explain where and what I did? |
I'm not sure I understand the question, the float.toFixed(2) isn't working? |
Exactly. Ok, so I am using the files cartAction: // TODO: Get couponDiscount value from db if (coupon.toLowerCase() === "familydiscount") { if (coupon.toLowerCase() === "militarydiscount") { if (coupon.toLowerCase() === "sacoleiraspecialty") { dispatch({ localStorage.setItem("coupon", JSON.stringify(coupon)); I added a coupon constant in the cart constant: export const CART_ADD_COUPON = "CART_ADD_COUPON"; Added to reducer: and in placeorderscreen is: if (cart.couponDiscount) { |
The major component is in placeorderscreen. So I have the product price for example $7. Then the fee which is like $3.30. Then I get the value from the action and multiply by the cart total. When I add .toFixed(2) or even without toFixes(2) it does nothing. Doesn't constrain to two variables |
Add toFixed to the final cart.totalPrice |
I did this: |
I don't understand why this is doing it because everything is using .toFixed(2) in terms of the totalPrice and all that |
You are multiplying the previous totalPrice with a new float value which will make it behave like that again |
Yay, it is working! Thanks. You have been so helpful |
I hate to keep bothering you but can we work on a vscode live share session. I started this feature but I was having multiple inputs and it was not passing to cartScreen. It's options |
I really appreciate everything you have done for me. I have been trying to get help from other people and all I gotten is I can't help you or I'm busy. So I appreciate you for helping me. It means alot. I know words may not mean a-lot, I would pay you if I had money. Honestly. As a 16 year old, I got into programming last year, and it has been a journey. A great one. |
Hey @AstroProjection I tried doing the tutorial and refining it a bit, and I can't get it to work. Can you check my latest code commit. Thnaks. |
You haven't pushed anything up |
Oh, I realized I did it on my other repo. Let me share you the link to that
repo. I changed the file userController.
https://github.com/talmax1124/cdshop
…On Wed, Jun 9, 2021 at 11:37 AM Akshay Hemant ***@***.***> wrote:
You haven't pushed anything up
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOVNS3SCFAWTAZQG3O5FK3LTR6DFLANCNFSM43XDGABA>
.
|
I forgot. I did it on another repo of mine: https://github.com/talmax1124/cdshop @AstroProjection |
Last changes were a month ago? |
Sorry, this is the link: https://github.com/talmax1124/creativeduoshopping-master @AstroProjection |
This is the actual one, the one I last sent. Sorry. @AstroProjection |
Can't seem to access the page |
Look at my profile talmax1124 and look for repo: creativeduoshopping-master |
Or try checking the link again @AstroProjection |
I got it working! @AstroProjection . This may sound stupid but I almost had paypal for the place-order screen instead of the order screen. Is there a way you can help me changing it? Thanks and have a great day or evening! |
i've tried it again right now and something is not right. Can you help me in this? @AstroProjection |
Nevermind got it working too! i just need help implementing stripe like this https://github.com/stripe-samples/checkout-one-time-payments or https://checkout.stripe.dev/preview @AstroProjection |
Awesome! see as you keep solving these issues it all starts to fall into place a little better :) |
i'll look into the stripe implementation and see if I can help you out with it |
Ok. Thanks Alot @AstroProjection ! |
Do you know by when you can have it ready? @AstroProjection |
Did you figure out how to do the stripe thing @AstroProjection |
Sorry, I've been preoccupied with work, couldn't find the time for it, I'll look at it over the weekend |
It's all good! I have been trying to add the payment before the order screen but I had to revert it because It was sending to sandbox URL. If you ever find a fix, I will appreciate it if you could teach me what I did wrong @AstroProjection |
Hello @AstroProjection I just wanted to see if you had time to accomplish the stripe thing? |
Also I found a bug when deleting the reviews. It deletes the rating but not how many review there was. For Example, the photo is after i deleted a review, it stays like there was a review made. @AstroProjection Update like 2 minutes after: |
Nice! sorry I've been swamped with work this last month, haven't had time to do my own thing, how did the stripe thing go? |
No Luck! I have been working on other things and work as well. I have done major improvements, just the stripe thing is the only thing I couldn't do. I don't know what to do. That's the reason I asked you. @AstroProjection |
@AstroProjection Could you finish the stripe thing? |
@AstroProjection or if you could help me implement Auth0 into the sign in. Or if you can help me implement payment buttons like Apple Pay or Google Pay. I really don't know how to any of these because I'm implementing some stuff. Thanks for the help! |
@AstroProjection Are you currently busy? Could you help me out in my other repository adding edit review but that only that user can edit it? |
Fixing the issue of Delete Product Review as discussed on bradtraversy/proshop_mern#141
Please update your 'master' branch to your latest changes and push it to origin
The text was updated successfully, but these errors were encountered: