Feature Implement

[AstroProjection]

Fixing the issue of Delete Product Review as discussed on bradtraversy/proshop_mern#141

Please update your 'master' branch to your latest changes and push it to origin

[talmax1124]

I don't see the PR

[AstroProjection]

Will do it, but I wanted to latest version of your main branch so that I can work off of that

[talmax1124]

Ok, just commited my latest changes

[AstroProjection]

I don't have access to push to your repository

[talmax1124]

Let me do that then

[talmax1124]

Try now

[AstroProjection]

#2

Verify and let me know.

[talmax1124]

It does nothing: [0] DELETE /api/products/6089626dcc7322a7134fa879/reviews 201 323.964 ms - 28

Once I click, the error does not show, but it does not delete. The thing above is the response from the terminal in VSCODE

@AstroProjection

[talmax1124]

[AstroProjection]

Could you send a pic of the payload that's being sent on the delete request as well as the headers which are being sent

[talmax1124]

![Uploading Screen Shot 2021-04-28 at 10.34.12 AM.png…]()

[AstroProjection]

Could you you send an screenshot of the payload, it should be the review data that we're sending from the frontend to the back

[talmax1124]

Where do I find the payload?

[talmax1124]

Screen.Recording.2021-04-28.at.11.25.41.AM.mov

[talmax1124]

Does this help? @AstroProjection
Do you think we will have time to complete it today?

[talmax1124]

@AstroProjection Once we finish this, the next thing I want to integrate is Options. I created a issue about this in the proshop repo as well

[AstroProjection]

#3 - this PR should resolve the issues

[talmax1124]

Yes it is working now

[talmax1124]

Ok, I implemented coupons. I think this may be a stupid fix, but when I do multiplication by 0.3 which is supposed to be 30% gives me a bunch of numbers after it. You know for example 3.2993448 when I have .toFixed(2). Any fixes you can think of?

[talmax1124]

You want me to explain where and what I did?

[AstroProjection]

I'm not sure I understand the question, the float.toFixed(2) isn't working?

[talmax1124]

Exactly. Ok, so I am using the files cartAction:
export const addCoupon = (coupon) => (dispatch) => {
let couponDiscount = 0;

// TODO: Get couponDiscount value from db

if (coupon.toLowerCase() === "familydiscount") {
couponDiscount = 3;
}

if (coupon.toLowerCase() === "militarydiscount") {
couponDiscount = 2;
}

if (coupon.toLowerCase() === "sacoleiraspecialty") {
couponDiscount = 4;
}

dispatch({
type: CART_ADD_COUPON,
payload: { coupon, couponDiscount },
});

localStorage.setItem("coupon", JSON.stringify(coupon));
localStorage.setItem("couponDiscount", JSON.stringify(couponDiscount));
};

I added a coupon constant in the cart constant: export const CART_ADD_COUPON = "CART_ADD_COUPON";

Added to reducer:
case CART_ADD_COUPON:
return {
...state,
coupon: action.payload.coupon,
couponDiscount: action.payload.couponDiscount,
};

and in placeorderscreen is:

if (cart.couponDiscount) {
cart.totalPrice *= Number(cart.couponDiscount).toFixed(2);
}

[talmax1124]

The major component is in placeorderscreen. So I have the product price for example $7. Then the fee which is like $3.30. Then I get the value from the action and multiply by the cart total. When I add .toFixed(2) or even without toFixes(2) it does nothing. Doesn't constrain to two variables

[AstroProjection]

Add toFixed to the final cart.totalPrice

[talmax1124]

I did this:
if (cart.couponDiscount) {
cart.totalPrice.toFixed(2) *= Number(cart.couponDiscount).toFixed(2);
}
and in terminal got: SyntaxError: /Users/carlitos/shop/frontend/src/screens/PlaceOrderScreen.js: Invalid left-hand side in assignment expression (75:4)

[talmax1124]

I don't understand why this is doing it because everything is using .toFixed(2) in terms of the totalPrice and all that

[AstroProjection]

if (cart.couponDiscount) {
cart.totalPrice *= Number(cart.couponDiscount).toFixed(2);
cart.totalPrice = cart.totalPrice.toFixed(2);
}

You are multiplying the previous totalPrice with a new float value which will make it behave like that again

[talmax1124]

Yay, it is working! Thanks. You have been so helpful

[talmax1124]

I hate to keep bothering you but can we work on a vscode live share session. I started this feature but I was having multiple inputs and it was not passing to cartScreen. It's options

[talmax1124]

I really appreciate everything you have done for me. I have been trying to get help from other people and all I gotten is I can't help you or I'm busy. So I appreciate you for helping me. It means alot. I know words may not mean a-lot, I would pay you if I had money. Honestly. As a 16 year old, I got into programming last year, and it has been a journey. A great one.

[talmax1124]

Hey @AstroProjection I tried doing the tutorial and refining it a bit, and I can't get it to work. Can you check my latest code commit. Thnaks.

[AstroProjection]

You haven't pushed anything up

[talmax1124]

Oh, I realized I did it on my other repo. Let me share you the link to that repo. I changed the file userController. https://github.com/talmax1124/cdshop

…

On Wed, Jun 9, 2021 at 11:37 AM Akshay Hemant ***@***.***> wrote: You haven't pushed anything up — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOVNS3SCFAWTAZQG3O5FK3LTR6DFLANCNFSM43XDGABA> .

[talmax1124]

I forgot. I did it on another repo of mine: https://github.com/talmax1124/cdshop @AstroProjection

[AstroProjection]

Last changes were a month ago?

[talmax1124]

Sorry, this is the link: https://github.com/talmax1124/creativeduoshopping-master @AstroProjection

[talmax1124]

This is the actual one, the one I last sent. Sorry. @AstroProjection

[AstroProjection]

Can't seem to access the page

[talmax1124]

Look at my profile talmax1124 and look for repo: creativeduoshopping-master

[talmax1124]

Or try checking the link again @AstroProjection

[talmax1124]

I got it working! @AstroProjection . This may sound stupid but I almost had paypal for the place-order screen instead of the order screen. Is there a way you can help me changing it? Thanks and have a great day or evening!

[talmax1124]

i've tried it again right now and something is not right. Can you help me in this? @AstroProjection

[talmax1124]

Nevermind got it working too! i just need help implementing stripe like this https://github.com/stripe-samples/checkout-one-time-payments or https://checkout.stripe.dev/preview @AstroProjection

[AstroProjection]

Awesome! see as you keep solving these issues it all starts to fall into place a little better :)

[AstroProjection]

i'll look into the stripe implementation and see if I can help you out with it

[talmax1124]

Ok. Thanks Alot @AstroProjection !

[talmax1124]

Do you know by when you can have it ready? @AstroProjection

[talmax1124]

Did you figure out how to do the stripe thing @AstroProjection

[AstroProjection]

Sorry, I've been preoccupied with work, couldn't find the time for it, I'll look at it over the weekend

[talmax1124]

It's all good! I have been trying to add the payment before the order screen but I had to revert it because It was sending to sandbox URL. If you ever find a fix, I will appreciate it if you could teach me what I did wrong @AstroProjection

[talmax1124]

Hello @AstroProjection I just wanted to see if you had time to accomplish the stripe thing?

[talmax1124]

Also I found a bug when deleting the reviews. It deletes the rating but not how many review there was. For Example, the photo is after i deleted a review, it stays like there was a review made. @AstroProjection

'

Update like 2 minutes after:
I fixed it, just made an equation to remove it by 1 since that is how many 1 comment is. In terms of review.

[AstroProjection]

Nice! sorry I've been swamped with work this last month, haven't had time to do my own thing, how did the stripe thing go?

[talmax1124]

No Luck! I have been working on other things and work as well. I have done major improvements, just the stripe thing is the only thing I couldn't do. I don't know what to do. That's the reason I asked you. @AstroProjection

[talmax1124]

@AstroProjection Could you finish the stripe thing?

[talmax1124]

@AstroProjection or if you could help me implement Auth0 into the sign in. Or if you can help me implement payment buttons like Apple Pay or Google Pay. I really don't know how to any of these because I'm implementing some stuff. Thanks for the help!

[talmax1124]

@AstroProjection Are you currently busy? Could you help me out in my other repository adding edit review but that only that user can edit it?