Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose private RSA key #407

Closed
wants to merge 15 commits into from
Closed

Don't expose private RSA key #407

wants to merge 15 commits into from

Conversation

Tirokk
Copy link
Member

@Tirokk Tirokk commented Oct 4, 2020

roschaefer Authored by roschaefer
Apr 4, 2019
Merged Apr 12, 2019

cc @Tirokk

Pullrequest

Issues

  • None

Checklist

  • None

How2Test

  • None

Todo

  • None

roschaefer and others added 15 commits April 4, 2019 18:02
@roschaefer
Don't expose private RSA key
8627d57 
cc @Tirokk
@Tirokk
Added Tests to "user_management.spec.js"
8713f61 
Implemented suppression of "publicKey", now commented out for testing approach.
Use port 4001 for querying, but forgot that I have to generate the user on the same port, before I can query it with generated "publicKey".
Do this in next commit.
@Tirokk
User to query for "publicKey" is generated on port "4001"
c4e57fc 
But still no "publicKey" is generated.
So wished failing test shows not "publicKey" except other than "null".
@Tirokk
Merge branch 'keep_private_rsa_key_secret' of https://github.com/Huma…
a995c84 
…n-Connection/Human-Connection into keep_private_rsa_key_secret_TirNew
@ulfgebhardt
Merge branch 'master' into keep_private_rsa_key_secret
ea2499f
@ulfgebhardt
Merge branch 'master' into keep_private_rsa_key_secret
851e691
@Tirokk
Merge branch 'master' of https://github.com/Human-Connection/Human-Co…
6794156 
…nnection into keep_private_rsa_key_secret_TirNew
@Tirokk
Query of users "publicKey" 'throws "Not Authorised!"'
95a0567 
Changes password and permission middleware.

Thanks for your big help @roschaefer !
@Tirokk
Backend test for query "publicKey" to asure that "privatKey" is gener…
b007015 
…ated

Minor approofments.
@roschaefer @Tirokk
Update backend/src/resolvers/user_management.spec.js
008d99c 
Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
@roschaefer @Tirokk
Update backend/src/resolvers/user_management.spec.js
828ca50 
Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
@roschaefer @Tirokk
Update backend/src/resolvers/user_management.spec.js
e5e1f0a 
Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
@Tirokk
Query of "publicKey" is now tested unauthenticated and authenticated
023c636
@roschaefer @Tirokk
Update backend/src/middleware/passwordMiddleware.js
0c8b478 
Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
@mattwr18
Remove redundant "not"
aadfd16
@Tirokk
Copy link
Member Author

Tirokk commented Oct 6, 2020

mattwr18 Authored by mattwr18
Oct 3, 2019

this was closed by Human-Connection/Human-Connection#1711

@Mogge Mogge closed this Oct 8, 2020
@ulfgebhardt ulfgebhardt deleted the pr406head branch January 7, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Github Import
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Tirokk @Mogge @roschaefer @ulfgebhardt @mattwr18