Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't expose private RSA key #407

Closed
wants to merge 15 commits into from
Closed

Don't expose private RSA key #407

wants to merge 15 commits into from

Commits on Apr 4, 2019

  1. Don't expose private RSA key 

    cc @Tirokk
    @roschaefer
    roschaefer committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    8627d57 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Added Tests to "user_management.spec.js" 

    Implemented suppression of "publicKey", now commented out for testing approach.
Use port 4001 for querying, but forgot that I have to generate the user on the same port, before I can query it with generated "publicKey".
Do this in next commit.
    @Tirokk
    Tirokk committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    8713f61 View commit details
    Browse the repository at this point in the history

  2. User to query for "publicKey" is generated on port "4001" 

    But still no "publicKey" is generated.
So wished failing test shows not "publicKey" except other than "null".
    @Tirokk
    Tirokk committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    c4e57fc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'keep_private_rsa_key_secret' of https://github.com/Huma… 

    …n-Connection/Human-Connection into keep_private_rsa_key_secret_TirNew
    @Tirokk
    Tirokk committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    a995c84 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into keep_private_rsa_key_secret

    @ulfgebhardt
    ulfgebhardt committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    ea2499f View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2019

  1. Merge branch 'master' into keep_private_rsa_key_secret

    @ulfgebhardt
    ulfgebhardt committed Apr 6, 2019
    Configuration menu
    Copy the full SHA
    851e691 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Merge branch 'master' of https://github.com/Human-Connection/Human-Co… 

    …nnection into keep_private_rsa_key_secret_TirNew
    @Tirokk
    Tirokk committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    6794156 View commit details
    Browse the repository at this point in the history

  2. Query of users "publicKey" 'throws "Not Authorised!"' 

    Changes password and permission middleware.

Thanks for your big help @roschaefer !
    @Tirokk
    Tirokk committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    95a0567 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Backend test for query "publicKey" to asure that "privatKey" is gener… 

    …ated

Minor approofments.
    @Tirokk
    Tirokk committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    b007015 View commit details
    Browse the repository at this point in the history

  2. Update backend/src/resolvers/user_management.spec.js 

    Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
    @roschaefer @Tirokk
    roschaefer and Tirokk committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    008d99c View commit details
    Browse the repository at this point in the history

  3. Update backend/src/resolvers/user_management.spec.js 

    Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
    @roschaefer @Tirokk
    roschaefer and Tirokk committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    828ca50 View commit details
    Browse the repository at this point in the history

  4. Update backend/src/resolvers/user_management.spec.js 

    Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
    @roschaefer @Tirokk
    roschaefer and Tirokk committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    e5e1f0a View commit details
    Browse the repository at this point in the history

  5. Query of "publicKey" is now tested unauthenticated and authenticated

    @Tirokk
    Tirokk committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    023c636 View commit details
    Browse the repository at this point in the history

  6. Update backend/src/middleware/passwordMiddleware.js 

    Co-Authored-By: Tirokk <wolle.huss@pjannto.com>
    @roschaefer @Tirokk
    roschaefer and Tirokk committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    0c8b478 View commit details
    Browse the repository at this point in the history

  7. Remove redundant "not"

    @mattwr18
    mattwr18 committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    aadfd16 View commit details
    Browse the repository at this point in the history