Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow nikic/php-parser 1.1 #3

Merged
merged 2 commits into from Feb 25, 2015
Merged

allow nikic/php-parser 1.1 #3

merged 2 commits into from Feb 25, 2015

Conversation

remicollet
Copy link
Contributor 

$ vendor/bin/phpunit 
PHPUnit 4.7-g7b9e68d by Sebastian Bergmann and contributors.

Configuration read from /work/GIT/CodeGenerationUtils/phpunit.xml.dist

...........S..............................I...................... 65 / 71 ( 91%)
......

Time: 120 ms, Memory: 11.00Mb

There was 1 incomplete test:

  1. CodeGenerationUtilsTest\Visitor\ClassClonerVisitorTest::testClonesClassIntoNonEmptyNodeList
    Still not clear thoughts on this...

There was 1 skipped test:

  1. CodeGenerationUtilsTest\GeneratorStrategy\EvaluatingGeneratorStrategyTest::testGenerateWithDisabledEval
    Ini setting "suhosin.executor.disable_eval" is needed to run this test

@remicollet
Copy link
Contributor Author

I don't know if you prefer ~1.0 (<2) of only 1.0 or 1.1

@Ocramius
Copy link
Owner

I'm actually fine with ~1.0

@Ocramius Ocramius self-assigned this Feb 25, 2015
@remicollet
Copy link
Contributor Author

I'm actually fine with ~1.0

Done

@Ocramius
Copy link
Owner

Thanks @remicollet! Waiting for travis and then merging :)

Ocramius added a commit that referenced this pull request Feb 25, 2015
@Ocramius
Merge pull request #3 from remicollet/issue-parser11
d27db31 
allow nikic/php-parser 1.1
@Ocramius Ocramius merged commit d27db31 into Ocramius:master Feb 25, 2015
@Ocramius Ocramius added this to the 0.3.1 milestone Feb 25, 2015
@Ocramius
Copy link
Owner

Done in release 0.3.1

@Ocramius Ocramius mentioned this pull request Feb 25, 2015
Merged
@dependabot dependabot bot mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remicollet @Ocramius