Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow nikic/php-parser 1.1 #30

Merged
merged 1 commit into from
Feb 25, 2015
Merged

allow nikic/php-parser 1.1 #30

merged 1 commit into from
Feb 25, 2015

Conversation

remicollet
Copy link
Contributor

As ocramius/code-generator-utils requires 1.0... not easy to test... have to hardly remplace vendor/nikic dir..

$ phpunit
PHPUnit 4.7-g7b9e68d by Sebastian Bergmann and contributors.

Configuration read from /work/GIT/GeneratedHydrator/phpunit.xml.dist

.............................I

Time: 211 ms, Memory: 11.50Mb

There was 1 incomplete test:

1) GeneratedHydratorTest\Functional\HydratorFunctionalTest::testDisabledMethod
Methods have to be disabled - currently only removing them

/work/GIT/GeneratedHydrator/tests/GeneratedHydratorTest/Functional/HydratorFunctionalTest.php:94

OK, but incomplete, skipped, or risky tests!
Tests: 30, Assertions: 84, Incomplete: 1.

@remicollet
Copy link
Contributor Author

As "name": "ocramius/code-generator-utils", better way to test this

    "nikic/php-parser":              "~1.1",
    "ocramius/code-generator-utils": "dev-master"

Still ok.

@Ocramius
Copy link
Owner

Re-running the build since Ocramius/CodeGenerationUtils#3 was merged

@Ocramius Ocramius self-assigned this Feb 25, 2015
@Ocramius Ocramius added this to the 1.1.1 milestone Feb 25, 2015
Ocramius added a commit that referenced this pull request Feb 25, 2015
@Ocramius
Merge pull request #30 from remicollet/issue-parser11
2c29e3a 
allow nikic/php-parser 1.1
@Ocramius Ocramius merged commit 2c29e3a into Ocramius:master Feb 25, 2015
@Ocramius
Copy link
Owner

👍 thanks @remicollet

@Ocramius
Copy link
Owner

Tagged in 1.1.1

@remicollet
Copy link
Contributor Author

Great thanks for the merge and the tag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remicollet @Ocramius