Skip to content

Commit

Permalink
Drop testing for "lowest" dependencies in PHP 8.0 upgrade (#161)
Browse files Browse the repository at this point in the history
As per composer/composer#9302, this is a known composer bug
that is not that relevant for this package for multiple reasons:

 1. the only real dependencies are `php` and `composer-runtime-api`, which are fixed
 2. we upgrade all dependencies whenever possible, and restrict the range too, via
    dependabot, so we don't keep old dependencies around for too long anyway
  • Loading branch information
Ocramius committed Oct 21, 2020
1 parent da77bb7 commit e85a7ea
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 17 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ jobs:
key: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"
restore-keys: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"

- name: "Install lowest dependencies"
if: ${{ matrix.dependencies == 'lowest' }}
run: "composer update --prefer-lowest --no-interaction --no-progress --no-suggest --ignore-platform-req=php"

- name: "Install highest dependencies"
if: ${{ matrix.dependencies == 'highest' }}
run: "composer update --no-interaction --no-progress --no-suggest --ignore-platform-req=php"
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/mutation-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ jobs:
key: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"
restore-keys: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"

- name: "Install lowest dependencies"
if: ${{ matrix.dependencies == 'lowest' }}
run: "composer update --prefer-lowest --no-interaction --no-progress --no-suggest --ignore-platform-req=php"

- name: "Install highest dependencies"
if: ${{ matrix.dependencies == 'highest' }}
run: "composer update --no-interaction --no-progress --no-suggest --ignore-platform-req=php"
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/phpunit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ jobs:
strategy:
matrix:
dependencies:
- "lowest"
- "highest"
- "locked"
- "classmap-authoritative"
Expand Down Expand Up @@ -54,10 +53,6 @@ jobs:
key: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"
restore-keys: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"

- name: "Install lowest dependencies"
if: ${{ matrix.dependencies == 'lowest' }}
run: "composer update --prefer-lowest --no-interaction --no-progress --no-suggest --ignore-platform-req=php"

- name: "Install highest dependencies"
if: ${{ matrix.dependencies == 'highest' }}
run: "composer update --no-interaction --no-progress --no-suggest --ignore-platform-req=php"
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/psalm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ jobs:
key: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"
restore-keys: "php-${{ matrix.php-version }}-${{ matrix.dependencies }}"

- name: "Install lowest dependencies"
if: ${{ matrix.dependencies == 'lowest' }}
run: "composer update --prefer-lowest --no-interaction --no-progress --no-suggest --ignore-platform-req=php"

- name: "Install highest dependencies"
if: ${{ matrix.dependencies == 'highest' }}
run: "composer update --no-interaction --no-progress --no-suggest --ignore-platform-req=php"
Expand Down

0 comments on commit e85a7ea

Please sign in to comment.