Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to PHPUnit 6 #49

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Update to PHPUnit 6 #49

merged 1 commit into from
Nov 20, 2017

Conversation

carusogabriel
Copy link
Contributor

As we support PHP 7, I've updated our suite of tests to PHPUnit 6.

Ocramius
Ocramius requested changes Nov 19, 2017
View reviewed changes
Copy link
Owner

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustments in .travis.yml and the phpunit config are needed

@Ocramius Ocramius added this to the 1.1.4 milestone Nov 19, 2017
@carusogabriel
Copy link
Contributor Author

@Ocramius Done. I've removed the --report-useless-tests command line option, that was removed in PHPUnit 6.

@Ocramius
Copy link
Owner

What about the strictness of that flag? Was it ported to a config?

@carusogabriel
Copy link
Contributor Author

PHPUnit is now strict about useless tests by default

Source: https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-6.0.md#changed-1

@Ocramius
Copy link
Owner

Awesome, thanks!

@Ocramius Ocramius merged commit 09bb6a9 into Ocramius:master Nov 20, 2017
@carusogabriel carusogabriel deleted the phpunit-6 branch November 20, 2017 13:32
@Ocramius Ocramius modified the milestones: 1.1.4, 1.2.0 Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius requested changes

Assignees

@carusogabriel carusogabriel

Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carusogabriel @Ocramius