[WIP] Skip properties when use ghost objects #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function testAuxiliarClassHasPublicPropetyNamedProperty9() | ||
| { | ||
| $objectWithPublicProperties = new ClassWithPublicProperties; | ||
| $this->assertObjectHasAttribute( |
There was a problem hiding this comment.
The test should assert that accessing the attribute does NOT cause lazy-loading
There was a problem hiding this comment.
To do that, throw an exception in the initializer, I'd say
malukenho
force-pushed
the
feature/allow-skipping-properties
branch
2 times, most recently
from
ad780a6
to
0fbb2be
Compare
| $ghostObject = $factory->createProxy( | ||
| $className, | ||
| function () { | ||
| }, |
There was a problem hiding this comment.
You should throw an exception in here
|
@malukenho the PR is incorrectly rebased. Did you refresh |
malukenho
force-pushed
the
feature/allow-skipping-properties
branch
from
0fbb2be
to
b23efd6
Compare
|
Closing here: please re-open from a clean branch, as this seems to mess up github big time: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linking #212