Merge release 2.10.1 into 2.11.x #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Reading a property from an interface proxy used to lead to a fatal error, but should be a notice instead.
…r` when generating notice emulation code Before this, the decision whether an interface was being proxied was delegated to the magic method generator, which led to an explosion in conditionals in upstream code. Here we instead pass the whole `ReflectionClass` for the parent symbol to the `PublicScopeSimulator`, therefore adding a single conditional to the source of `PublicScopeSimulator`, leading to reduced complexity.
…rage, we raise the `minMsi` again We now cover more edges in `PublicScopeSimulator`, and that should be reflected in our mutation score requirements.
…n-accessing-dynamic-property-of-proxied-interface #642 fix fatal error when accessing a dynamic property of a proxied interface (refactored)
…imulator` respects `:void` no-return-value semantics
Before this, generating `unset()` code while forgetting to pass all parameters to `PublicScopeSimulator` led to a
crash due to `__unset(): void { ... }` containing `return $value` statements (invalid starting from PHP 7.3.0)
…/PRoxyManagerTest/Functional` (and removed coverage)
… `$operationType` parameter
… positioning, indentation)
…ameter` when not generating `__set` code While changing this may seem like a BC Break, pre-existing usages of `PublicScopeSimulator` when combining `$operationType = 'set'` and `$valueParameter !== null` was most likely a bug that did not surface in consumer code yet. This change highlights the bug, and leads to generating cleaner code for `__set`, as well as correcting `public function __unset() : void` codegen, which previously generated invalid code that contained `return <expression>;` statements (crashing since PHP 7.3.0).
…ass-integration-test' into 2.10.x Fix #649
Ocramius
deleted the
2.10.x-merge-up-into-2.11.x_5fec8fce435468.86689243
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 2.10.1
2.10.1
bug
bug,question