Exclude urls from css imports #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanbuck
reviewed
Sep 28, 2020
| ${captureQuotedWord} | ||
| ['"] # beginning quote | ||
| (?<$1> | ||
| (?!https?:\/\/) # exclude urls |
There was a problem hiding this comment.
Using a negative look ahead, is what I ended up doing for #1033 as well.
stefanbuck
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This is another thing I found while working on #905. I was trying to exclude things like
url("https://...")so we didn't do needless lookups and it turns out the same thing happens with css imports. I'm sure this exists for LESS and SASS as well but didn't dig into those yet.I'm wondering if there's a better way to handle this. Any ideas?
You can see an example of this here: