Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for url() values in css #905

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

xt0rted
Copy link
Member

@xt0rted xt0rted commented Apr 20, 2020

Pull Request Badge

Checklist:

  • If this PR is a new feature, please provide at least one example link
  • Make sure all of the significant new logic is covered by tests

Here's some examples of this working.

This is a feature that'll never work for everyone since the assets could be anywhere in the repo, but it does handle the basics which should be good enough.

I still need to add some tests for this and some feedback on the adjustment to the sass plugin.

Closes #447

@xt0rted xt0rted requested a review from stefanbuck April 20, 2020 23:17
Copy link
Member

@stefanbuck stefanbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straight forward to me. As mentioned on the issue, ideally OctoLinker would be able to resolve all relative files regardless of the language, but in the meantime this is defiantly better than nothing.

@xt0rted xt0rted changed the base branch from master to main September 21, 2020 21:49
@xt0rted xt0rted marked this pull request as ready for review September 29, 2020 18:49
@stefanbuck stefanbuck merged commit c710eca into OctoLinker:main Sep 30, 2020
@xt0rted xt0rted deleted the css-url-support branch September 30, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support for url() in css
2 participants