Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ${CMAKE_SOURCE_DIR} with ${PROJECT_SOURCE_DIR} #157

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

cehberlin
Copy link
Contributor

Replaced ${CMAKE_SOURCE_DIR} with ${PROJECT_SOURCE_DIR}to enable embedding of octomap into other source structures, for instance through the add_subdirectory() command

…nable embedding of octomap into other source structures, for instance through the add_subdirectory()
@ahornung ahornung merged commit 817af60 into OctoMap:devel Feb 24, 2017
@ahornung
Copy link
Member

@cehberlin I just found that this places the compiled binaries and libs always in the sub-project lib/bin dirs (e.g. octovis in octomap/octovis/bin/octovis) no matter how the project is compiled.

When compiling only a sub-project then this should be the case, but when compiling the complete distribution, the binaries should end up in the "main" bin dir (e.g. octovis in octomap/bin/octovis).

Could you have a look and change it accordingly with a PR? There could be a switch depending on whether CMake was originally run for the octomap-distribution project.

I'm currently looking for loose ends for a soon-ish new release.

@ahornung
Copy link
Member

This could also be achieved by placing links in the top-level bin directory, not sure if the libs should be all collected in one place anyways. This also relates to #133

ahornung added a commit that referenced this pull request Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants