🎨 Protect agains null scripts sent by client

See #3827
OctoPrint · Nov 30, 2020 · ba27cdf · ba27cdf
1 parent 5cb2564
commit ba27cdf
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/octoprint/server/api/settings.py b/src/octoprint/server/api/settings.py
@@ -9,6 +9,7 @@
 
 from flask import abort, jsonify, make_response, request
 from flask_login import current_user
+from past.builtins import basestring
 from werkzeug.exceptions import BadRequest
 
 import octoprint.plugin
@@ -932,6 +933,8 @@ def _saveSettings(data):
             for name, script in data["scripts"]["gcode"].items():
                 if name == "snippets":
                     continue
+                if not isinstance(script, basestring):
+                    continue
                 s.saveScript(
                     "gcode", name, script.replace("\r\n", "\n").replace("\r", "\n")
                 )