Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload does not support the Chinese name, suggesting that the file type error #1181

Closed
xioxin opened this issue Jan 9, 2016 · 2 comments
Closed

Comments

@xioxin
Copy link

xioxin commented Jan 9, 2016

鸟笼.gcode

@GitIssueBot
Copy link

Hi @xioxin,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Please take a look at the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2016-01-23 16:00) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

foosel added a commit that referenced this issue Jan 11, 2016
Just stripping anything non-ASCII leads to errors with UTF-8 only
filenames.

Closes #1181
@foosel
Copy link
Member

foosel commented Jan 11, 2016

OctoPrint renames the files to ASCII based file names (to make some things easier, might be revisited in the future). So for it stripped anything non-ASCII from the name in order to do that. This has now been changed to use a slugify library to convert UTF8 characters into ASCII representations.

Available on maintenance and devel branch. Will be released with 1.2.9.

@foosel foosel closed this as completed Jan 11, 2016
@foosel foosel added needs information More information is needed to further process this issue or PR and removed status:incomplete ticket needs information More information is needed to further process this issue or PR labels Aug 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants