Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging level for "octoprint" appears on Logging levels even though it isn't been logged #3950

Closed
eyal0 opened this issue Jan 13, 2021 · 3 comments · Fixed by #3951
Closed

Logging level for "octoprint" appears on Logging levels even though it isn't been logged #3950

eyal0 opened this issue Jan 13, 2021 · 3 comments · Fixed by #3951
Labels
approved Issue has been approved by the bot or manually for further processing done Done but not yet released grabbed Grabbed by someone from the community to be implemented/fixed improvement Improving functionality, behaviour, UX, ...
Milestone
1.6.0

Comments

@eyal0
Copy link
Contributor

eyal0 commented Jan 13, 2021

What were you doing?

  1. Click on settings.
  2. Click on "Logging"
  3. See this:

image

It appears as if I have debug logging set for both octoprint.events.fire and octoprint. However, only the first one is set. The second one hasn't yet been added.

What did you expect to happen?

I expected only octoprint.events.fire to be listed because that's the only one that I have set.

What happened instead?

I saw octoprint listed for DEBUG even though I didn't enable that logging.

Version of OctoPrint

OctoPrint 1.6.0.dev178+g498463f5c Python 3.7.3

Operating System running OctoPrint

Linux

Browser and version of browser, operating system running browser

Chrome

I have read the FAQ.
@github-actions github-actions bot added the triage This issue needs triage label Jan 13, 2021
@eyal0
Copy link
Contributor Author

eyal0 commented Jan 13, 2021

This is related to #3949
This is also related to #3948

@eyal0
Copy link
Contributor Author

eyal0 commented Jan 13, 2021

I will fix this.

@GitIssueBot GitIssueBot added the approved Issue has been approved by the bot or manually for further processing label Jan 13, 2021
eyal0 added a commit to eyal0/OctoPrint that referenced this issue Jan 13, 2021
@eyal0
Add empty component to availableLoggers list
e1f9340 
This fixes OctoPrint#3950
@cp2004 cp2004 added grabbed Grabbed by someone from the community to be implemented/fixed improvement Improving functionality, behaviour, UX, ... and removed triage This issue needs triage labels Jan 13, 2021
@eyal0 eyal0 mentioned this issue Jan 13, 2021
Merged
10 tasks
@cp2004 cp2004 added the pr pending A pull request addressing this has been submitted but not yet merged label Jan 13, 2021
@foosel foosel added the done Done but not yet released label Jan 18, 2021
@foosel foosel added this to the 1.6.0 milestone Jan 18, 2021
@foosel
Copy link
Member

foosel commented Jan 18, 2021

Thanks for the PR! It's merged and will be part of 1.6.0!

@cp2004 cp2004 removed the pr pending A pull request addressing this has been submitted but not yet merged label Jan 19, 2021
@foosel foosel closed this as completed in 85919a1 Apr 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
approved Issue has been approved by the bot or manually for further processing done Done but not yet released grabbed Grabbed by someone from the community to be implemented/fixed improvement Improving functionality, behaviour, UX, ...
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

Empty new logger eyal0/OctoPrint
4 participants
@foosel @eyal0 @GitIssueBot @cp2004