Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Send long filenames to Marlin when the LFN_WRITE capability is set. #4494

Closed
nophead opened this issue Apr 22, 2022 · 10 comments
Closed
Assignees
Labels
done Done but not yet released request Feature request
Milestone

Comments

@nophead
Copy link
Contributor

nophead commented Apr 22, 2022

Is your feature request related to a problem? Please describe.

The latest Marlin bugfix branch has support for writing SD files with long filenames but OctoPrint sends 8.3 names, so only files written to the card externally show long filenames in the listing. Files upload via OctoPrint always have short names.

Describe the solution you'd like

As the description. Full support for long filenames seems to be the future, so the core OctoPrint should support it, either by recognising LFN_WRITE or having another comms option.

Describe alternatives you've considered

No response

Additional context

No response

@github-actions github-actions bot added the request Feature request label Apr 22, 2022
@nophead nophead changed the title [Request] Send long filenames to Marlin when the WRITE_LFN capability is set. [Request] Send long filenames to Marlin when the LFN_WRITE capability is set. Apr 22, 2022
@foosel
Copy link
Member

foosel commented May 25, 2022

either by recognising LFN_WRITE

Is that a newly introduced capability flag that gets included in the M115 response?

@foosel foosel added the needs information More information is needed to further process this issue or PR label May 25, 2022
@foosel foosel removed the needs information More information is needed to further process this issue or PR label May 25, 2022
@foosel foosel added this to the 1.9.0 milestone May 25, 2022
@foosel
Copy link
Member

foosel commented May 25, 2022

Thanks, that clarifies that.

@foosel foosel self-assigned this Nov 7, 2022
foosel added a commit that referenced this issue Nov 9, 2022
If LFN_WRITE capability is reported as supported,
OctoPrint by default now will upload SD files
to the printer under their full name instead of
shortening it to DOS conventions.

The primary name as reported by the firmware
(first entry in the M20 output) is still
considered the main name and used for any file
operations like selecting or deleting. So, if
the firmware supports a DOS name here, that's
also what OctoPrint will (continue to) use for
any such operations.

Implements #4494
@foosel
Copy link
Member

foosel commented Nov 9, 2022

Implemented and ready for 1.9.0.

If LFN_WRITE capability is reported as supported, OctoPrint by default now will upload SD files to the printer under their full name instead of shortening it to DOS conventions.

The primary name as reported by the firmware (first entry in the M20 output) is still considered the main name and used for any file operations like selecting or deleting. So, if the firmware supports a DOS name here, that's also what OctoPrint will (continue to) use for any such operations.

@foosel foosel added the done Done but not yet released label Nov 9, 2022
@nophead
Copy link
Contributor Author

nophead commented Nov 9, 2022

Thanks, I will look forward to 1.9 being released. Shame I can only run it on machine until Raspberry PIs become available again.

@foosel
Copy link
Member

foosel commented Nov 9, 2022

I hope you are aware that it also works just fine on any old laptop or other SBC? There's also a nifty little script by @paukstelis that sets everything up for you against multiple Linux distributions: https://github.com/paukstelis/octoprint_install

@nophead
Copy link
Contributor Author

nophead commented Nov 9, 2022

Yes but I have 5 printers with the original model B running old versions of OctoPrint. I have only one with an RPI0 W2 running the latest Octoprint.

If I update the printers to another random SBC I would have to model it in NopSCADlib to make new mounting brackets and possibly replace the cameras. I can wait because the printers work fine with old versions of OctoPrint and don't need the SD card to print good quality.

@paukstelis
Copy link

Yes but I have 5 printers with the original model B running old versions of OctoPrint. I have only one with an RPI0 W2 running the latest Octoprint.

If I update the printers to another random SBC I would have to model it in NopSCADlib to make new mounting brackets and possibly replace the cameras. I can wait because the printers work fine with old versions of OctoPrint and don't need the SD card to print good quality.

Keep in mind that you can also easily run multiple printers off of a single Pi or any other hardware. I have another script for that: https://github.com/paukstelis/octoprint_deploy

@nophead
Copy link
Contributor Author

nophead commented Nov 9, 2022

Not the way I run them. I use the GPIO to control the power supply and the lights and use the serial port on the GPIO for comms and the camera port. There is only one camera port and one serial port per RPI.

No doubt a multicore RPI could run more printers but it would need to use the USB for comms and cameras and then there would be earth loop problems.

@foosel
Copy link
Member

foosel commented May 23, 2023

1.9.0 has been released.

@foosel foosel closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Done but not yet released request Feature request
Projects
Status: Done
Development

No branches or pull requests

4 participants