Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.9.0rc2] Auth workflow fails due to CSRF cookie not being set #4755

Closed
foosel opened this issue Mar 9, 2023 · 2 comments
Closed

[1.9.0rc2] Auth workflow fails due to CSRF cookie not being set #4755

foosel opened this issue Mar 9, 2023 · 2 comments
Assignees
Labels
bug Issue describes a bug done Done but not yet released

Comments

@foosel
Copy link
Member

foosel commented Mar 9, 2023

Problem

The auth workflow from the appkeys plugin fails if the user is logged in/has a remember me cookie set, but no CSRF cookie is already present:

image

If the user is not yet logged in and no remember me cookie is present, going through the login dialog first covers up the issue.

Solution

It looks like the workflow isn't setting the CSRF cookie on template rendition, like login dialog and core UI do, so that needs to be looked into.

@foosel foosel added the bug Issue describes a bug label Mar 9, 2023
@foosel foosel self-assigned this Mar 9, 2023
foosel added a commit that referenced this issue Mar 9, 2023
@foosel
Copy link
Member Author

foosel commented Mar 9, 2023

Fix ready for 1.9.0rc3

@foosel foosel added the done Done but not yet released label Mar 9, 2023
@foosel
Copy link
Member Author

foosel commented Mar 22, 2023

1.9.0rc3 is out.

@foosel foosel closed this as completed Mar 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue describes a bug done Done but not yet released
Projects
Status: Done
Development

No branches or pull requests

1 participant