Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.10.0rc1] No warning when overwriting a file on upload #4943

Closed
3 of 4 tasks
larp-welt opened this issue Feb 2, 2024 · 4 comments
Closed
3 of 4 tasks

[1.10.0rc1] No warning when overwriting a file on upload #4943

larp-welt opened this issue Feb 2, 2024 · 4 comments
Labels
bug Issue describes a bug done Done but not yet released regression Regression in a release candidate or stable release

Comments

@larp-welt
Copy link

The problem

When I upload a gcode file with the same name as an existing one, no window message pops up to warn me and to ask me what to do.

Did the issue persist even in safe mode?

Yes, it did persist

If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)

No response

Version of OctoPrint

1.10.0rc1

Operating system running OctoPrint

OctoPi

Printer model & used firmware incl. version

Pursa Mk3S+

Browser and version of browser, operating system running browser

Version 120.0.6099.199 (Offizieller Build) for TUXEDO Computers GmbH (64-Bit) running on Tuxedo

Checklist of files to include below

  • Systeminfo Bundle (always include!)
  • Contents of the JavaScript browser console (always include in cases of issues with the user interface)
  • Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
  • GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)

Additional information & file uploads

Kazam_screencast_00000.mp4

octoprint-systeminfo-20240202194250.zip
console.log
@github-actions github-actions bot added the triage This issue needs triage label Feb 2, 2024
@jneilliii
Copy link
Contributor

This seems to be reproducible inside a folder. Uploading to the root folder I do get the overwrite/rename prompt as expected.

@jneilliii
Copy link
Contributor

Along with that, if a file exists in the root uploads folder, attempting to upload the same named file in a folder shows the overwrite/rename prompt.

@jneilliii jneilliii added the bug Issue describes a bug label Feb 3, 2024
@foosel foosel added regression Regression in a release candidate or stable release and removed triage This issue needs triage labels Feb 5, 2024
@foosel foosel mentioned this issue Feb 5, 2024
Closed
foosel added a commit that referenced this issue Feb 5, 2024
@foosel
🐛 Fix fetching of file details for existence check
311faeb 
That used to be correct and got changed by a PR and
overlooked in review, 💩 happens.

Fixes #4943
@foosel
Copy link
Member

foosel commented Feb 5, 2024

That was an error crept in through the PR that added the file details and which I overlooked during review, sh*t happens ^^

Now fixed for 1.10.0rc2, thanks for reporting!

@foosel foosel added the done Done but not yet released label Feb 5, 2024
@foosel
Copy link
Member

foosel commented Feb 12, 2024

1.10.0rc2 has just been released 👍

@foosel foosel closed this as completed Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue describes a bug done Done but not yet released regression Regression in a release candidate or stable release
Projects
OctoPrint Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@foosel @larp-welt @jneilliii