Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature graph missing history for higher extruders (only visible in 1.10.0rc3) #4980

Closed
smurfix opened this issue Mar 29, 2024 · 9 comments
Labels
bug Issue describes a bug done Done but not yet released
Milestone

Comments

@smurfix
Copy link
Contributor

smurfix commented Mar 29, 2024

Is your feature request related to a problem? Please describe.

After an UI reload (or when opening Octoprint on another host after starting to print), the temperature graph looks like this:

image

Describe the solution you'd like

Octoprint should remember all temperatures, not just the first extruder's.

Describe alternatives you've considered

No response

Additional context

No response

@github-actions github-actions bot added the request Feature request label Mar 29, 2024
@jneilliii
Copy link
Contributor

IIRC you are running OctoPrint 1.10.0rc3?

@foosel
Copy link
Member

foosel commented Mar 29, 2024

This sounds rather like a bug, so please share a system info bundle.

In general it's always a good idea to share one with a reproduction if you stumble across some behaviour that you want to see changed, even as request, as it very much increases the likelihood that I can actually reproduce the behaviour and see what I can do about it.

Help me to help you instead of making me constantly ask for details, thanks.

@smurfix
Copy link
Contributor Author

smurfix commented Mar 30, 2024

@jneilliii Yes.

@foosel Here it is, during a print that exhibits the problem.

octoprint-systeminfo-20240330105323.zip


Bundles:

edited by @github-actions to add bundle viewer links

@foosel foosel added bug Issue describes a bug and removed request Feature request labels Apr 2, 2024
@foosel foosel changed the title [Request] Remember all extruders' temperatures [1.10.0rc3] Temperature graph missing history for higher extruders Apr 2, 2024
@foosel
Copy link
Member

foosel commented Apr 2, 2024

So this is actually a bug, but not a regression in 1.10.0rc3. OctoPrint actually does keep the full history. The problem is that the graph doesn't render it right on load, because at that point it hasn't yet received the information on the configured printer profile, thus falls back on the default values, and therefore refuses to draw anything but the first extruder and the bed. I haven't confirmed it yet, but I'm pretty sure the chamber temperature would be affected here as well.

It's not a regression because it was always behaving this way, it simply didn't show because so far the temperature graph always started at the time of the reload and no history at all was rendered, that's a new feature in 1.10.0.

I'm scheduling a fix for this for 1.10.1 - it's a bug, but frankly too minor to justify yet another RC round on its own.

@foosel
Copy link
Member

foosel commented Apr 2, 2024

Sidenote, please don't unpack and repack the system info bundle, and also:

octoprint.version: 1.3.12+g91435d3cd.dirty

this version that your instance is reporting there is definitely not 1.10.0rc3 even though the code might be, and that commit is unknown in OctoPrint/OctoPrint and apparently from a fork of you (which would also explain the complete outdated version that's being reported).

When opening tickets of any kind, make sure you can reproduce whatever you are opening them about on an official release, not any forks, especially not dirty ones.

@foosel foosel added this to the 1.10.x milestone Apr 2, 2024
@foosel foosel changed the title [1.10.0rc3] Temperature graph missing history for higher extruders Temperature graph missing history for higher extruders (only visible in 1.10.0rc3) Apr 2, 2024
@smurfix
Copy link
Contributor Author

smurfix commented Apr 2, 2024

Sidenote, please don't unpack and repack the system info bundle

The problem was that one of the log files was too big. I had to truncate it.

Sorry about the version, that was my installer dropping the tag on the workshop floor. The code itself is 100% official Octoprint. I'll fix that nonsense in time for the next bug report.

@foosel
Copy link
Member

foosel commented Apr 2, 2024

Gotcha.

I've also just pushed a new version of the bundle viewer that now supports the actual bundle being in a subfolder (which was the reason why I mentioned it), so IF you should have to repack things in the future due to size reasons, it should now no longer cause issues with the viewer.

@foosel
Copy link
Member

foosel commented Apr 3, 2024

Good news I guess, we need another RC for 1.10.0 after all, and I'll include this fix in that.

@foosel foosel modified the milestones: 1.10.x, 1.10.0 Apr 3, 2024
@foosel foosel added the done Done but not yet released label Apr 11, 2024
@foosel
Copy link
Member

foosel commented Apr 11, 2024

Fixed in 1.10.0rc4.

@foosel foosel closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue describes a bug done Done but not yet released
Projects
Status: Done
Development

No branches or pull requests

3 participants