Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.10.0rc3] "Mass production" achievement ignores uploads #4984

Closed
1 of 4 tasks
smurfix opened this issue Apr 5, 2024 · 4 comments
Closed
1 of 4 tasks

[1.10.0rc3] "Mass production" achievement ignores uploads #4984

smurfix opened this issue Apr 5, 2024 · 4 comments
Labels
bug Issue describes a bug done Done but not yet released
Milestone

Comments

@smurfix
Copy link
Contributor

smurfix commented Apr 5, 2024

The problem

When you do a test print / tweak dimensions / repeat cycle and re-use the file name, that shouldn't count as mass production.

Thus

  1. upload file named X
  2. print X
  3. upload different file named X
  4. print the new X
  5. repeat eight more times

shouldn't yield an achievement. Or, well, maybe it should give you a different achievement, like "ecologist" because you're recycling (file names, that is …), but not the "mass production" one.

Did the issue persist even in safe mode?

Yes, it did persist

If you could not test in safe mode, please state why ("currently printing" is NOT an excuse!)

No response

Version of OctoPrint

1.10.0rc3

Operating system running OctoPrint

Debian

Printer model & used firmware incl. version

No response

Browser and version of browser, operating system running browser

No response

Checklist of files to include below

  • Systeminfo Bundle (always include!)
  • Contents of the JavaScript browser console (always include in cases of issues with the user interface)
  • Screenshots and/or videos showing the problem (always include in case of issues with the user interface)
  • GCODE file with which to reproduce (always include in case of issues with GCODE analysis or printing behaviour)

Additional information & file uploads

yes I know, the version number in the bundle is still wrong.

octoprint-systeminfo-20240328221240.zip

@github-actions github-actions bot added the triage This issue needs triage label Apr 5, 2024
@jneilliii
Copy link
Contributor

Probably easy to adjust to use file hash instead of name here for calculation?

@foosel foosel changed the title "Mass production" achievement ignores uploads [1.10.0rc3] "Mass production" achievement ignores uploads Apr 8, 2024
@foosel
Copy link
Member

foosel commented Apr 8, 2024

Nah, the file hash isn't always available, and generating it on the fly could take too long.

Taking the modification time into account should work (though in most cases not for SD card files, but there's nothing I can do here)

foosel added a commit that referenced this issue Apr 8, 2024
Modifications of the file should reset the counter.

Closes #4984
@foosel
Copy link
Member

foosel commented Apr 8, 2024

I've now added the timestamp of the last modification to the check. Ready for 1.10.0rc4

@foosel foosel added bug Issue describes a bug done Done but not yet released and removed triage This issue needs triage labels Apr 8, 2024
@foosel foosel added this to the 1.10.0 milestone Apr 8, 2024
@foosel
Copy link
Member

foosel commented Apr 11, 2024

Fixed in 1.10.0rc4.

@foosel foosel closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue describes a bug done Done but not yet released
Projects
Status: Done
Development

No branches or pull requests

3 participants