Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User account management from CLI #3227

Merged
merged 3 commits into from Jul 22, 2019
Merged

User account management from CLI #3227

merged 3 commits into from Jul 22, 2019

Conversation

aliaksei135
Copy link
Contributor

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

Adds User account management from the command line through the user command group.
Commands added are add_user, remove_user and change_password.

How was it tested? How can it be tested by the reviewer?

Manual testing of commands, nosetests all pass.

Any background context you want to provide?

What are the relevant tickets if any?

Solves #1239.

Screenshots (if appropriate)

Further notes

Server needs a reboot after any user commands to load new users.yaml.
Needs documentation and updating of "Forgot password" link on login page once documented.

Add forgot password link at login

Update AUTHORS.md
Copy link
Member

@foosel foosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great idea! I have two minor issues, apart from those this is ready to merge! 👍

src/octoprint/users.py Outdated Show resolved Hide resolved
src/octoprint/cli/user.py Outdated Show resolved Hide resolved
@foosel foosel added this to the 1.3.12 milestone Jul 18, 2019
@foosel foosel added the needs some work There are some things to do before this PR can be merged label Jul 18, 2019
@aliaksei135 aliaksei135 marked this pull request as ready for review July 18, 2019 14:42
Copy link
Member

@foosel foosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot something

src/octoprint/users.py Outdated Show resolved Hide resolved
@foosel foosel merged commit 09e0239 into OctoPrint:maintenance Jul 22, 2019
@foosel
Copy link
Member

foosel commented Jul 22, 2019

👍

@foosel foosel removed the needs some work There are some things to do before this PR can be merged label Jul 22, 2019
@aliaksei135 aliaksei135 deleted the cliUserAccounts branch September 26, 2019 09:06
@aliaksei135 aliaksei135 restored the cliUserAccounts branch September 26, 2019 09:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants