Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Temps #3506

Merged
merged 1 commit into from Apr 6, 2020
Merged

Conversation

jneilliii
Copy link
Contributor

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

Added modifications to allow for the injection of additional temperature data by plugins, which allows for graphing by a replacement Temperature tab.

How was it tested? How can it be tested by the reviewer?

Ran in development environment for some time both with default temperature tab and custom OctoPrint-PlotlyTempGraph tab that graphs added data injected by plugins, ie my test plugin here.

Any background context you want to provide?

What are the relevant tickets if any?

#2194, #1187, #321, #3261

Screenshots (if appropriate)

Further notes

Additional discussion on the forum here.

@foosel foosel merged commit 79cd98d into OctoPrint:maintenance Apr 6, 2020
@foosel foosel added this to the 1.4.1 milestone Apr 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants