Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where _simulateTemps may never reach target temp #3553

Merged

Conversation

kantlivelong
Copy link
Contributor

What does this PR do and why is it necessary?

When setting temperatures whilst using the Virtual Printer there is a chance the target is never truly reached but is instead within ~0.5C. This handles the condition where the temperature difference is less than the delta and makes the next temperature change equal to the difference.

How was it tested? How can it be tested by the reviewer?

  1. Set target temperature
  2. Wait (Note: It seems that target temp may be reached if sitting in a breakpoint and that is because of the timeDiff calculation)
  3. Observe

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

@foosel foosel merged commit ed1b02d into OctoPrint:maintenance May 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants