Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add move file capabilities #3609

Merged
merged 2 commits into from Jun 23, 2020
Merged

Conversation

jneilliii
Copy link
Contributor

@jneilliii jneilliii commented Jun 20, 2020

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

This PR adds a button to the files sidebar that allows for moving a file to a sub folder via modal pop up, and adds new permission MOVE_FILE.

How was it tested? How can it be tested by the reviewer?

Ran it inside development environment and created several nested folders and moved files between the different levels.

Any background context you want to provide?

Feature request on the issue tracker.

What are the relevant tickets if any?

#3596

Screenshots (if appropriate)

image

image

Further notes

I'm sure there's some changes you'll want to make. I added some visual cues in the UI if there are any errors when trying to move the file, for example file already exists. Would probably be good to add another comparison to self.enableMove function to handle cases where there are no folders.

@foosel foosel merged commit 70ba9d5 into OctoPrint:maintenance Jun 23, 2020
@jneilliii jneilliii deleted the move_files branch June 23, 2020 15:08
@foosel foosel added this to the 1.4.1 milestone Jun 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants