馃拕 Better fix for styling of the pluginmanager #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better fix than my hack styling that navbar before. Co-Authored-By: LazeMSS <69049371+LazeMSS@users.noreply.github.com>
cp2004
changed the title
github-actions
bot
added
the
approved
|
@foosel what do you think about this going for 1.6.0rc2? The previous change broke things like themeify & UI Customizer, which it might be nice to avoid. |
|
Thanks for the reminder, this one completely managed to pass me by 馃え |
4 tasks
|
Looks great @cp2004 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better fix than my hack styling that navbar before.
Co-Authored-By: LazeMSS 69049371+LazeMSS@users.noreply.github.com
What does this PR do and why is it necessary?
Adjusts the styling in the pluginmanager to avoid the issue of hardcoded styles in the navbar, which break themes used. This fix gets rid of that sticky styling (which actually isn't widely used when I looked at it and still achieves the same thing. Styling is not my strong point 馃槃.
How was it tested? How can it be tested by the reviewer?
Made the changes then opened the navbar, confirmed that there were no dual scrollbars and the navbar remained, so the only scrollbar is the table below now.
Any background context you want to provide?
#3835 and the initial suggestion #3801.
What are the relevant tickets if any?
See above
Screenshots (if appropriate)
Further notes
I would like this to make it to 1.6.0rc, since it is an issue brought in since 1.5.x