Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bedZ should be a float #4135

Merged
merged 1 commit into from May 18, 2021
Merged

bedZ should be a float #4135

merged 1 commit into from May 18, 2021

Conversation

eyal0
Copy link
Contributor

@eyal0 eyal0 commented May 11, 2021

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

bedZ is a float

How was it tested? How can it be tested by the reviewer?

I didn't test it at all.

What are the relevant tickets if any?

4c4570e

@github-actions
Copy link

Automatic PR Validation failed

There were one or more problems detected with this PR:

  • The PR's target branch rc/maintenance is not among the allowed target branches: maintenance, devel, staging/maintenance, staging/devel. Please only create PRs against these.

Please take a look at the Contribution Guidelines of this repository and make sure that the PR follows them. Thank you!

I'm just a bot 🤖 that does automatic checks, a human will intervene if I've made a mistake.

@github-actions github-actions bot added the needs some work There are some things to do before this PR can be merged label May 11, 2021
@github-actions
Copy link

Automatic PR Validation failed

There were one or more problems detected with this PR:

  • The PR's target branch rc/maintenance is not among the allowed target branches: maintenance, devel, staging/maintenance, staging/devel. Please only create PRs against these.

Please take a look at the Contribution Guidelines of this repository and make sure that the PR follows them. Thank you!

I'm just a bot 🤖 that does automatic checks, a human will intervene if I've made a mistake.

1 similar comment
@github-actions
Copy link

Automatic PR Validation failed

There were one or more problems detected with this PR:

  • The PR's target branch rc/maintenance is not among the allowed target branches: maintenance, devel, staging/maintenance, staging/devel. Please only create PRs against these.

Please take a look at the Contribution Guidelines of this repository and make sure that the PR follows them. Thank you!

I'm just a bot 🤖 that does automatic checks, a human will intervene if I've made a mistake.

@eyal0 eyal0 changed the base branch from rc/maintenance to maintenance May 11, 2021 15:35
@github-actions github-actions bot added approved Issue has been approved by the bot or manually for further processing and removed needs some work There are some things to do before this PR can be merged labels May 11, 2021
eyal0 referenced this pull request May 11, 2021
People might not actually always have a home command in their GCODE
files, so let's just depend on the so far pretty universal truth that
printers have a bed at z=0 and that is just always the lowest Z of a
printed object. And just in case, let's make this value configurable
because the printer gods only know what some people might come up with
in terms of experimental printer mechanics that end up with negative z
coordinates or a bed at z=100.

Closes #4036
@foosel foosel added this to the 1.7.0 milestone May 18, 2021
@foosel foosel merged commit ac07c77 into OctoPrint:maintenance May 18, 2021
@foosel
Copy link
Member

foosel commented May 18, 2021

Indeed it should, thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Issue has been approved by the bot or manually for further processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants