Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PULL_REQUEST_TEMPLATE.md; Highlight branch names #4573

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 13, 2022

Highlight branch names, file names, and executable names using backticks. #4571 (comment)

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch if it's a completely
    new feature, or maintenance if it's a bug fix or improvement of
    existing functionality for the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

How was it tested? How can it be tested by the reviewer?

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

@github-actions github-actions bot added meta Related to GitHub repository metadata targets maintenance The PR targets the maintenance branch approved Issue has been approved by the bot or manually for further processing labels Jul 13, 2022
Highlight branch names, file names, and executable names using backticks.
@foosel foosel changed the base branch from maintenance to master August 1, 2022 09:41
@foosel foosel merged commit 5753ee3 into OctoPrint:master Aug 1, 2022
@cclauss cclauss deleted the patch-2 branch August 1, 2022 09:42
@foosel
Copy link
Member

foosel commented Aug 1, 2022

I originally did not do this since the template is consumed in plain text in the editor and I figured the formatting via backticks might confuse people more than help in that context, but I'm happy to give this a try and proof my worries wrong.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Issue has been approved by the bot or manually for further processing meta Related to GitHub repository metadata targets maintenance The PR targets the maintenance branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants