Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suspicious Plugin Activity] M33 Fio #470

Closed
jneilliii opened this issue May 11, 2020 · 8 comments
Closed

[Suspicious Plugin Activity] M33 Fio #470

jneilliii opened this issue May 11, 2020 · 8 comments

Comments

@jneilliii
Copy link
Contributor

jneilliii commented May 11, 2020

Which Plugin? (URL to plugin page on plugin repository)

M33 Fio

What's the suspicious activity?

Automatically enrolls OctoPrint instance into announcements without an opt-in option that points to a web site https://exploitkings.com/scripts/M33 Fio.xml here and server is not responding.

Link to ticket on the plugin's issue tracker about the issue

donovan6000/M33-Fio#257

@donovan6000
Copy link
Contributor

IIRC, OctoPrint gives you the option to disable announcements in the Announcements section of the settings. You should be able to disable M33 Fio announcements there.

If that's not satisfactory, then I'm more than happy to merge in a pull request that comments out this line which enables the M33 Fio announcements by default.

On a side note, I was upgrading my server last night which ended up taking down exploitkings.com for several hours. The RSS feed provided by https://exploitkings.com/scripts/M33 Fio.xml is back up now.

@jneilliii
Copy link
Contributor Author

Ok, I sent a PR, but based on a couple of other issues I see in the repo, I'm not sure it's going to fix newer OctoPrint versions or not. I've been unable to get any feedback in the community forum post about it over here.

@foosel
Copy link
Member

foosel commented Jul 29, 2020

@donovan6000 do you still intend to merge the PR provided by @jneilliii?

@GitIssueBot
Copy link

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/extension-of-announcement-plugin/22473/3

@foosel
Copy link
Member

foosel commented Jul 30, 2021

I guess that's a no. I'm wondering, this plugin is pretty much completely dead in the water, incompatible to current versions of OctoPrint, to Python 3... shouldn't we just delist it altogether at this point?

@kantlivelong
Copy link
Contributor

shouldn't we just delist it altogether at this point?

👍

@jneilliii
Copy link
Contributor Author

Agree

@foosel foosel closed this as completed in fc9349f Jul 30, 2021
@foosel
Copy link
Member

foosel commented Jul 30, 2021

Delisted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants