Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Abandoned Plugin] OctoPrint Klipper Plugin #599

Closed
AliceGrey opened this issue Aug 29, 2020 · 10 comments · Fixed by #616
Closed

[Abandoned Plugin] OctoPrint Klipper Plugin #599

AliceGrey opened this issue Aug 29, 2020 · 10 comments · Fixed by #616

Comments

@AliceGrey
Copy link
Contributor

Which Plugin? (URL to plugin page on plugin repository)
https://github.com/mmone/OctoprintKlipperPlugin

Ticket on plugin's issue tracker confirming abandonment:
Last release was 2 years ago
https://github.com/mmone/OctoprintKlipperPlugin/releases/tag/0.2.5

Is there someone open to adopting it? ("no" or @-mention user):
I am open to adopting it

@jneilliii
Copy link
Contributor

@AliceGrey you linked to the releases, which is not necessarily an indication of abandonment, although based on the open issue count and pull requests it does in fact appear to be abandoned.

@mmone it appears there are several pull requests against your repo that will fix several issues, etc. Are you no longer actively developing this plugin? If you are not or we don't hear back from you within 14 days we will transition this plugin to @AliceGrey's fork and update the official plugin repo accordingly.

@AliceGrey relative to that transition, I'm curious if you merged in all those Pull Requests that fix other issues in your fork?

@AliceGrey
Copy link
Contributor Author

@jneilliii
I pulled in the PR's except for mmone/OctoprintKlipperPlugin#64
I have yet to review it fully. The other two PR's resolved the issues mentioned in the original PR's and have been merged. I also have confirmed in a local dev environment that the plugin runs on python 3 after some minor tweaks.

@jneilliii
Copy link
Contributor

Perfect, if we don't hear back from @mmone we'll make the switch.

@jneilliii
Copy link
Contributor

Just one final follow-up @mmone, if we don't hear back from you in the next 7 days we will transition this official listing to @AliceGrey's maintained fork.

@jneilliii
Copy link
Contributor

@AliceGrey ok, all I need from you now that we've waited for the proper number of days is a PR for the plugin repo md page with corrected URLs to your repo, etc. Once I've gotten that and reviewed we'll submit the announcement for people to manually reinstall to get them back in line for future software update checks.

@cowboy3d
Copy link

Just saw this activity... after having created a pull request against my repository. @AliceGrey: Have a look at https://github.com/cowboy3d/OctoprintKlipper3Plugin if you're interested to see what I have changed to make it work with python 3.
Thank you for taking this over and good luck!

@GitIssueBot
Copy link

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/upgrade-your-octoprint-install-to-python-3/23973/84

@jneilliii
Copy link
Contributor

PR merged @AliceGrey, thanks for adopting this plugin and keeping it alive. @foosel ready for a change notice.

@jneilliii
Copy link
Contributor

Disregard Gina, I just realized I can copy the last one you did. I'm pretty sure I understand how it works. Will submit a PR for your review just to make sure.

@foosel
Copy link
Member

foosel commented Sep 15, 2020

PR review and merged, you did do it perfectly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants