Disposing Asynchronously #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # source/Halibut.Tests/Transport/ConnectionManagerFixture.cs
# Conflicts: # source/Halibut.Tests/Transport/ConnectionPoolFixture.cs # source/Halibut/Transport/ConnectionManager.cs # source/Halibut/Transport/ConnectionPool.cs
# Conflicts: # source/Halibut.Tests/Support/TestConnection.cs # source/Halibut.Tests/Transport/ConnectionPoolFixture.cs # source/Halibut/HalibutRuntime.cs # source/Halibut/Transport/ConnectionManager.cs # source/Halibut/Transport/ConnectionManagerAsync.cs # source/Halibut/Transport/ConnectionPool.cs # source/Halibut/Transport/ConnectionPoolAsync.cs # source/Halibut/Transport/IConnectionManager.cs # source/Halibut/Transport/IConnectionPool.cs # source/Halibut/Transport/SecureClient.cs # source/Halibut/Transport/SecureListeningClient.cs # source/Halibut/Transport/SecureWebSocketClient.cs
|
This pull request has been linked to Shortcut Story #53211: 🎉 🎉 🎉 Make Halibut Support Async RPC Calls 🎉 🎉 🎉. |
# Conflicts: # source/Halibut/ServiceModel/PendingRequestQueueAsync.cs # source/Halibut/Transport/SecureConnection.cs
sburmanoctopus
requested review from
acodrington,
LukeButters and
nathanwoctopusdeploy
acodrington
approved these changes
Aug 16, 2023
| public abstract class AsyncDisposableStream : Stream | ||
| #if NETFRAMEWORK | ||
| , IAsyncDisposable | ||
| #endif |
There was a problem hiding this comment.
Truly, truly awful 😆
It's good we're keeping this hidden
| @@ -99,7 +119,7 @@ public async Task<IConnection> AcquireConnectionAsync(ExchangeProtocolBuilder ex | |||
| Tuple<IConnection, Action> CreateNewConnection(ExchangeProtocolBuilder exchangeProtocolBuilder, IConnectionFactory connectionFactory, ServiceEndPoint serviceEndpoint, ILog log, CancellationToken cancellationToken) | |||
| { | |||
| var lazyConnection = new Lazy<IConnection>(() => connectionFactory.EstablishNewConnection(exchangeProtocolBuilder, serviceEndpoint, log, cancellationToken)); | |||
| var connection = new DisposableNotifierConnection(lazyConnection, OnConnectionDisposed); | |||
| var connection = new DisposableNotifierConnection(lazyConnection, OnConnectionDisposed, OnConnectionDisposedAsync); | |||
There was a problem hiding this comment.
Note: This sync implementation is slated for removal for the context of other readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-53211]
Background
As part of making Halibut async, we need to ensure we dispose of things asynchronously as well.
Results
Related to OctopusDeploy/Issues#8266
Before
The following places were found to have paths that would require async disposal. These were being disposed synchronously.
After
The green classes in the spreadsheet are not disposed asynchronously.
We did not change
usingstatements to `await using' statements in this PR. This touched over 20 files, so will be assessed and implemented in a different PR.To ensure .NET 4.8 code could compile and use
IAsyncDisposable, we had to import theMicrosoft.Bcl.AsyncInterfacespackage.How to review this PR
Quality ✔️
Pre-requisites