Await using #436
Merged
Await using #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # source/Halibut.Tests/Transport/ConnectionManagerFixture.cs
# Conflicts: # source/Halibut.Tests/Transport/ConnectionPoolFixture.cs # source/Halibut/Transport/ConnectionManager.cs # source/Halibut/Transport/ConnectionPool.cs
# Conflicts: # source/Halibut.Tests/Support/TestConnection.cs # source/Halibut.Tests/Transport/ConnectionPoolFixture.cs # source/Halibut/HalibutRuntime.cs # source/Halibut/Transport/ConnectionManager.cs # source/Halibut/Transport/ConnectionManagerAsync.cs # source/Halibut/Transport/ConnectionPool.cs # source/Halibut/Transport/ConnectionPoolAsync.cs # source/Halibut/Transport/IConnectionManager.cs # source/Halibut/Transport/IConnectionPool.cs # source/Halibut/Transport/SecureClient.cs # source/Halibut/Transport/SecureListeningClient.cs # source/Halibut/Transport/SecureWebSocketClient.cs
# Conflicts: # source/Halibut/ServiceModel/PendingRequestQueueAsync.cs # source/Halibut/Transport/SecureConnection.cs
# Conflicts: # source/Halibut/Transport/ConnectionManager.cs # source/Halibut/Transport/ConnectionPool.cs
|
This pull request has been linked to Shortcut Story #53211: 🎉 🎉 🎉 Make Halibut Support Async RPC Calls 🎉 🎉 🎉. |
|
[sc-57124] |
# Conflicts: # source/Halibut.Tests/Timeouts/SendingAndReceivingRequestMessagesTimeoutsFixture.cs # source/Halibut/Transport/DiscoveryClient.cs # source/Halibut/Transport/Protocol/MessageSerializer.cs # source/Halibut/Transport/SecureListener.cs # source/Halibut/Transport/SecureWebSocketListener.cs
|
This pull request has been linked to Shortcut Story #53211: 🎉 🎉 🎉 Make Halibut Support Async RPC Calls 🎉 🎉 🎉. |
sburmanoctopus
commented
Aug 20, 2023
| var e = (await AssertAsync.Throws<HalibutClientException>(() => echoServiceTheErrorWillHappenOn.SayHelloAsync(stringToSend))).And; | ||
| var e = (await AssertAsync.Throws<HalibutClientException>(() => | ||
| { | ||
| var stringToSend = Some.RandomAsciiStringOfLength(numberOfBytesBeforePausingAStream * 20); |
There was a problem hiding this comment.
It was driving me nuts debugging in this area, and having VS take ages to "evaluate local variables" because of this large string.
So I made sure it was no longer in scope. Solved!
LukeButters
reviewed
Aug 21, 2023
| @@ -23,7 +23,13 @@ public TcpTunnel(TcpClient fromClient, TcpClient toClient, ILogger logger) | |||
|
|
|||
| public async Task Tunnel(CancellationToken cancellationToken) | |||
| { | |||
| #if !NETFRAMEWORK | |||
There was a problem hiding this comment.
If only dotnet had #define or better yet virtual threads.
LukeButters
approved these changes
Aug 21, 2023
|
[sc-57123] |
|
This pull request has been linked to Shortcut Story #57123: RewindableBufferStream needs an async Dispose method (and that to be tested). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-53211]
Background
Continuing on from making disposing async, we need to make disposal with
usingstatements become async.Results
Related to OctopusDeploy/Issues#8266
Before
Whenever something that supports async operations is disposed, it does the disposal synchronously on the thread. This blocks the thread if disposal involves things like IO.
After
We now try to use
await usinginstead ofusingdo that any asynchronous operations done during disposal will no longer block the calling thread..NET 4.8 Complications
Streams in .NET 4.8 do not support
IAsyncDisposable. This means we cannot addawaittousingstatements.This was fixed by wrapping the
awaitin a#ifRewindableBufferStream
We also made
RewindableBufferStreamimplementIAsyncDisposable. This allowed us to usingawait usingwhenever we interacted with this type of stream.Using Our Streams
We made all our streams extend
IAsyncDisposableso that they would work in .NET 4.8 withawait usingHow to review this PR
Quality ✔️
Pre-requisites