Added support for netstandard2.0 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # source/Halibut.Tests/UsageFixture.cs
MichaelJCompton
approved these changes
Dec 19, 2017
markryd
reviewed
Dec 20, 2017
| @@ -25,10 +25,9 @@ enum HANDLE_FLAGS : uint | |||
|
|
|||
| public class SecureListener : IDisposable | |||
| { | |||
| #if CAN_GET_SOCKET_HANDLE | |||
| [DllImport("kernel32.dll", SetLastError = true)] | |||
| static extern bool SetHandleInformation(IntPtr hObject, HANDLE_FLAGS dwMask, HANDLE_FLAGS dwFlags); | |||
There was a problem hiding this comment.
Is this going to explode on non-windows?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
Newtonsoft.Jsonversion is10.0.3appsettings.json, but viaConfigurationManagerjust like the netfx buildChanges
netstandard2.0netstandardbuild is now almost identical to thenetfxbuildNotes
WebSocket Polling connections cannot be initiated on .NET Core. However it can accept incoming WebSocket requests.