Always make available trace logs #557
Conversation
| // Best effort clean-up, but we don't want to | ||
| // fail the test because we couldn't delete this file | ||
| } | ||
| cancellationTokenSource.Cancel(); |
There was a problem hiding this comment.
No need to delete the log file.
but we do await the writing of logs, since we really want to know if writing logs doesn't work.
LukeButters
changed the title
LukeButters
requested review from
nathanwoctopusdeploy,
sburmanoctopus and
acodrington
| } | ||
|
|
||
| public bool CopyLogFileToArtifacts() | ||
| public static DirectoryInfo LogFileDirectory() |
There was a problem hiding this comment.
Maybe this doesn't need to be public anymore
| Logger = new SerilogLoggerBuilder() | ||
| .SetTraceLogFileLogger(traceLogFileLogger) | ||
| .Build() | ||
| .ForContext(GetType()); | ||
|
|
||
| Logger.Information("Trace log file {LogFile}", traceLogFileLogger.logFilePath); |
There was a problem hiding this comment.
Thanks for this bit, I've got some WIP code to associate the TeamCity artifact with the test run so the trace log file can be accessed in-line in the build log, but there's still some TeamCity black magic I need to figure out to get it to work.
This will help in the meantime!
There was a problem hiding this comment.
Ah nice!
I also like this message for local development, since when the test is run the first line is "here is more info if you need it"
There was a problem hiding this comment.
Yep, it was on my to-do list for that exact reason, but got distracted by the TeamCity black magic and it didn't make it to a PR.
Background
We always recorded trace logs to file, this PR changes the tests so that those trace logs are always available.
This means:
This test will also print the location of the trace log for easy debugging.
How to review this PR
Quality ✔️
Pre-requisites