Build with .NET 8 #580
Closed
Build with .NET 8 #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # source/Halibut/Transport/SecureListener.cs
| @@ -108,7 +108,7 @@ ITargetDefinition CompileDefinition(ITargetDefinition targetDefinition, [CanBeNu | |||
| Target TestWindowsNet48 => _ => TestDefinition(_, CompileNet48, "net48", runDotMemoryTests: true); | |||
|
|
|||
| [PublicAPI] | |||
| Target TestWindowsNet60 => _ => TestDefinition(_, CompileNet60, "net6.0", runDotMemoryTests: true); | |||
| Target TestWindowsNet80 => _ => TestDefinition(_, CompileNet80, "net8.0", runDotMemoryTests: true); | |||
There was a problem hiding this comment.
I think we would want to keep build net6.0 and test net6.0 and then add the net8.0 versions.
There was a problem hiding this comment.
Thanks, I'd been meaning to run this PR through with someone from SaST to talk about things like this!
| @@ -51,10 +51,11 @@ | |||
| <PackageReference Include="Serilog.Sinks.ColoredConsole" Version="3.0.1" /> | |||
| </ItemGroup> | |||
|
|
|||
| <PropertyGroup Condition=" '$(TargetFramework)' == 'net48' "> | |||
| <PropertyGroup Condition=" '$(TargetFramework)' == 'net4.8' "> | |||
There was a problem hiding this comment.
Is this correct?
There was a problem hiding this comment.
It's wrong, it should be "net48". Perils of putting down a PR for a week or two then picking it back up again, sorry
| <DefineConstants>$(DefineConstants);SUPPORTS_WEB_SOCKET_CLIENT;DOES_NOT_SUPPORT_CANCELLATION_ON_SOCKETS</DefineConstants> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" '$(TargetFramework)' == 'net6.0' Or '$(TargetFramework)' == 'net8.0' "> |
There was a problem hiding this comment.
The general plan we've been following is:
- Switch the compilers to use .NET 8
- Build the library only targeting .NET 6 unless there's some special reason not to
- Have the tests run on both .NET6 and .NET8
But Halibut is complicated and messy, let's have a chat about the strategy for it
| @@ -8,10 +8,11 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="!$([MSBuild]::IsOSUnixLike())"> | |||
| <TargetFrameworks>net48;net6.0;net8.0</TargetFrameworks> | |||
There was a problem hiding this comment.
net6.0 and net8.0 aren't double-ups?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a customer of Octopus Deploy? Please contact our support team so we can triage your PR, so that we can make sure it's handled appropriately.
Background
Results
Fixes https://github.com/OctopusDeploy/Issues/issues/... (optional public issue)
Fixes https://github.com/OctopusDeploy/ResearchAndDevelopment/issues/... (optional private issue)
See How we use GitHub Issues (including this flowchart
Before
After
How to review this PR
Quality ✔️
Pre-requisites