Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 Special Header Content-Type not being set properly #5709

Closed
flin-8 opened this issue Jul 17, 2019 · 1 comment · Fixed by OctopusDeploy/Calamari#416
Closed

S3 Special Header Content-Type not being set properly #5709

flin-8 opened this issue Jul 17, 2019 · 1 comment · Fixed by OctopusDeploy/Calamari#416
Assignees
@flin-8
Labels
kind/bug This issue represents a verified problem we are committed to solving size/small ~1 day
Milestone
2019.7.5

Comments

@flin-8
Copy link

flin-8 commented Jul 17, 2019 •
edited
Loading

The bug

Related to #5302 , except this time it's

Content-Type

We should also review what other special properties need to be handled.

Steps to reproduce

  1. Add an S3 step to a project and choose a package
  2. Add a multi/single file selection
  3. As part of the selection add a metadata value with the Content-Type key
  4. Upload the file(s)
  5. Notice the use of x-amz-meta- as a prefix.

Affected versions

Octopus Server:2018.4.0-2019.7

Workarounds

Set the content-type manually in a subsequent step.

Links

https://secure.helpscout.net/conversation/903466719/47200?folderId=2981192
#5302
@flin-8 flin-8 added kind/bug This issue represents a verified problem we are committed to solving size/small ~1 day labels Jul 17, 2019
@flin-8 flin-8 mentioned this issue Jul 22, 2019
Merged
flin-8 added a commit to OctopusDeploy/Calamari that referenced this issue Jul 23, 2019
@flin-8
Support more AWS S3 headers like Content-Type (#416)
7753d34 
* Support more AWS S3 headers like Content-Type

Fixes: OctopusDeploy/Issues#5709
@flin-8 flin-8 self-assigned this Jul 23, 2019
@octoreleasebot octoreleasebot added this to the 2019.7.5 milestone Jul 29, 2019
@lock
Copy link

lock bot commented Oct 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flin-8 flin-8

Labels
kind/bug This issue represents a verified problem we are committed to solving size/small ~1 day
Projects
None yet
Milestone
2019.7.5
Development

Successfully merging a pull request may close this issue.

Support more AWS S3 headers like Content-Type OctopusDeploy/Calamari
2 participants
@flin-8 @octoreleasebot