Update serverspec to get better network port closed test #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have better "is port not listening" test in serverspec with mizzy/specinfra#716, we can uncomment some tests that weren't working so well due to ports on windows staying in a TIME_WAIT state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have better "is port not listening" test in serverspec with @benPearce1's fix in SpecInfra, we can uncomment some tests that weren't working so well due to ports on windows staying in a TIME_WAIT state.
@benPearce1 - tagging you on this as you've been in this space this week with the AzureVMExtension.
@andrewabest - tagging you as an fyi as you said you had been heavily into DSC in the past