Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of SQL Server for integration tests #216

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

geofflamrock
Copy link
Contributor

@geofflamrock geofflamrock commented Aug 5, 2024

A new version of SQL Server 2019 - Cumulative Update 28 has changed the path to the sqlcmd utility in the docker image. This caused our integration tests to fail because we are using that path in a health check.

This PR pins the version of SQL Server back to CU27 to get the build back to 💚 to allow us some breathing room to update properly.

@geofflamrock geofflamrock requested a review from a team as a code owner August 5, 2024 01:53
@geofflamrock geofflamrock marked this pull request as draft August 5, 2024 01:53
@geofflamrock geofflamrock removed the request for review from a team August 5, 2024 01:54
Copy link
Contributor

@stevencl840 stevencl840 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

@geofflamrock geofflamrock marked this pull request as ready for review August 5, 2024 02:53
@geofflamrock geofflamrock merged commit 06840dd into main Aug 5, 2024
6 checks passed
@geofflamrock geofflamrock deleted the geoffl/pin-sql-server-version branch August 5, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants