feat: Added build summary with list of packages that were pushed #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hnrkndrssn
commented
Jul 14, 2022
•
hnrkndrssn
commented
borland
suggested changes
Jul 14, 2022
| async pushPackage(): Promise<void> { | ||
| info('🔣 Parsing inputs...') | ||
| const cliLaunchConfiguration = this.generateLaunchConfig() | ||
|
|
||
| const options: ExecOptions = { | ||
| listeners: { | ||
| stdline: input => this.stdline(input) | ||
| stdline: async input => await this.stdline(input) |
There was a problem hiding this comment.
ExecOptions.stdline expects a void function, so it will ignore the Promise here and won't await it.
In practice it's probably OK, but worst-case scenario is that perhaps lines could get written out of order because it will call stdline in quick succession while previous async tasks are floating in the background?
The async part seems to be because you used the GitHub actions markdown summary builder thing.
Suggest keeping stdline as a sync function, and just collect all the stuff into an array, and call createBuildSummary later on after the process has completed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.