-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added build summary with list of packages that were pushed #253
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0faaacf
chore: update package push log message
hnrkndrssn 10636c6
feat: add build summary with list of packages that were pushed
hnrkndrssn d223248
chore: fix eslint issues
hnrkndrssn a8783e6
chore: tweak build summary layout
hnrkndrssn 7dd81a1
chore: try and codeify package
hnrkndrssn 1b38020
chore: more tweaks
hnrkndrssn f96138b
chore: more tweaks
hnrkndrssn ba0acfa
chore: push multiple packages as part test
hnrkndrssn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExecOptions.stdline expects a void function, so it will ignore the Promise here and won't await it.
In practice it's probably OK, but worst-case scenario is that perhaps lines could get written out of order because it will call stdline in quick succession while previous async tasks are floating in the background?
The async part seems to be because you used the GitHub actions markdown summary builder thing.
Suggest keeping stdline as a sync function, and just collect all the stuff into an array, and call createBuildSummary later on after the process has completed.