Fix the cloud region data source #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borland
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Some drive-by suggestions (because I'm always happy to see progress on terraform/go!) on the Github actions / test side of things, mostly to help make it more understandable.
I'll leave approval to modern deployments, but LGTM if you update the old node version and don't use apt-get to install gotestsum 😄
zentron
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug at #580.
The cloud region data source was the only one that removed the
endpointfield from the schema. This in turn broke the data source when it tried to flatten targets into the returned results.Since other data sources leave the
endpointfield in the schema, this PR removes the line that deletes theendpointfield.To speed up the integration tests, the
hashicorp-forge/go-test-split-action@v1action has been added. This runts the integration tests across 15 nodes, reducing the test time to under ten minutes (down from an hour).The tests were also updated to run against Octopus 2023.4.