Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add container options to kubernetes resource #622

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

zentron
Copy link
Contributor

@zentron zentron commented Mar 27, 2024

Background

Adds support for setting the ContainerOptions property on Kubernetes Targets

Results

Fixes: #608

Example

resource octopusdeploy_kubernetes_cluster_deployment_target test_eks{
  cluster_url                       = "https://cluster"
  environments                      = ["${octopusdeploy_environment.test_environment.id}"]
  name                              = "Test"
  ...
  container_options                 = "--priveleged"

Copy link
Collaborator

@tleed5 tleed5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, before you merge this change could you regenerate the docs i.e. run go generate main.go in the project root

@zentron
Copy link
Contributor Author

zentron commented Mar 28, 2024

Thanks @tleed5 . Looks like there docs are a bit buggy since it seems to be adding all properties to all targets. Will consider that another task to sort out.

@zentron zentron merged commit 1e47a13 into main Mar 28, 2024
37 checks passed
@zentron zentron deleted the robe/container-options branch March 28, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose kubernetes cluster deployment target container options
2 participants