Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rendering for submodules #40

Closed
wants to merge 3 commits into from

Conversation

dreh23
Copy link

@dreh23 dreh23 commented Mar 22, 2017

With the global switch git_respect_submodules = True it is possible to have the history log of every added submodule rendered. This is useful if you are compiling a documentation from several different git repositories.

With the global switch git_respect_submodules = True it is
possible to have the history log of every added submodule
rendered. This is useful if you are compiling a documentation
from several different git repositories.
@dreh23
Copy link
Author

dreh23 commented Mar 22, 2017

#39

johannesa added 2 commits March 22, 2017 13:45
Added os.path to strip out last component. There is no difference
in the rendered document, but it matches old behaviour of just
returning directory not document.
@dreh23
Copy link
Author

dreh23 commented Mar 22, 2017

I have two .. git_changelog:: one in the main "books" one in a git submodule "book1"

Test Framework fails, although it works. If I output srcdir and Repo I get:

u'srcdir:/home/me/dev/books'                                                                                     
<git.Repo "/home/me/dev/books/.git">
u'srcdir:/home/me/dev/books/docs/include/book1'                                               
<git.Repo "/home/me/dev/books/.git/modules/docs/include/book1">

I believe the testing framework is not anticipating this Path. Any input is appreciated.

@OddBloke
Copy link
Owner

@dreh23 This branch now has some conflicts; are you interested in refreshing it against the latest master?

@OddBloke
Copy link
Owner

@dreh23 I just suggested a way of doing this with existing features in #39; I'm going to close this out until we confirm that it's actually needed. Thanks!

@OddBloke OddBloke closed this Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants