Converting node/element type to integer values #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanhenneking
changed the title
|
Stefan,
I have looked it up. It looks good. Any particular reason why are you switching from `medg’ to ‘medge’ ?
What can I help with at this point ?
L
|
Since we introduced a global parameter |
|
Understood. L
… Since we introduced a global parameter MEDG in the data structure module, I needed to resolve conflicts with subroutines that had local variables named medg (due to Fortran's case insensitivity). I changed the local parameters from medg to medge to resolve the conflict.
> Stefan, I have looked it up. It looks good. Any particular reason why are you switching from `medg’ to ‘medge’ ? What can I help with at this point ? L
|
This was referenced Feb 27, 2023
1 task
Merged
|
Merging this into |
jdmorap
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Introducing type parameters in data structure. * Converting type to integer value in src code. * minor * type conversion of VECTOR_POISSON * type conversion of MAXWELL GALERKIN * type conversion of MPI TEST program * type conversion of POISSON GALERKIN * type conversion of POISSON PRIMAL DPG * type conversion of SHEATHED HOSE * type conversion of LASER COMMON * type conversion of LASER UW_COUPLED * bug fix * remove unused * minor change to gitignore * fix bug in href * minor * implicit none and consistent style * minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines
integerparameters for node and element types inmodule node_typeswhich are then used inELEMS(element)%etypeandNODES(node)%ntypeinstead of the previouscharacter(len=4)typesELEMS(element)%typeandNODES(node)%type.This change increases the performance of type comparisons significantly. See also: #67