Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fortran style #75

Merged
merged 117 commits into from
Mar 17, 2023
Merged

Fortran style #75

merged 117 commits into from
Mar 17, 2023

Conversation

stefanhenneking
Copy link
Contributor

@stefanhenneking stefanhenneking commented Feb 28, 2023 •
edited

Most of the changes in this PR fall into the following categories:

  • Removing common blocks
  • Adding implicit none statements
  • Adding DEBUG_MODE preprocessor flags for iprint sections
  • Converting .F to .F90 standard
  • Modernizing some of the Fortran language
  • Adjusting Fortran style to be more consistent within hp3D
  • Some code documentation (doxygen)
  • Moving unused and/or obsolete files into separate folders
  • Some improvements to test

Closes

Depends on #69

@stefanhenneking stefanhenneking added enhancement New feature or request WIP Work in progress labels Feb 28, 2023
@stefanhenneking
various updates, modernizing language
441d836
@stefanhenneking
consolidating cross_product routines
e71aaea
@stefanhenneking
implicit none for geom3D
6cb8e04
@stefanhenneking
keep_time f90
6532f36
@stefanhenneking
implicit none geom
d1d0a3a
@stefanhenneking
removing obsolete files in constrs
f843533
@stefanhenneking
removing obsolete routines
06d0986
@stefanhenneking
converting isgn to f90
e464384
@stefanhenneking
removing obsolete module
3926166
@stefanhenneking
moving obsolete file
af45719
@stefanhenneking
moving unused utility routines
f1b9461
@stefanhenneking
locate_char f90
0aa4777
@stefanhenneking
moving unused utility routine
36546b7
@stefanhenneking
updating encod/decod utilities to f90.
ece3245
@stefanhenneking
updated sorting routines to f90
81603bc
@stefanhenneking
updating style of utility routines
0e597fc
@stefanhenneking
updated style of numerics routines and removed obsolete file.
2b3e58f
@stefanhenneking
minor
b5039de
@stefanhenneking
implicit none for max rule routine.
a193ad9
@stefanhenneking
minor
9419532
@stefanhenneking
updated style of datstrs routines
139f1ab
@stefanhenneking
fixed bug - missing initialization
4ec25f6
@stefanhenneking
added debug flags
b23aa64
@stefanhenneking
added implicit none and debug flags
e54a2a0
@stefanhenneking
added implicit none and debug flags
8329b42
@stefanhenneking
moved unused files
66e0d0a
This was referenced Mar 12, 2023
Merged
Merged
This was linked to issues Mar 13, 2023
Convert fixed-format Fortran to modern Fortran #74
Closed
Implicit save declaration with locally initialized variables #98
Closed
This was referenced Mar 16, 2023
Open
Merged
@stefanhenneking stefanhenneking added ready-for-review Ready to be reviewed and removed WIP Work in progress labels Mar 17, 2023
@stefanhenneking stefanhenneking marked this pull request as ready for review March 17, 2023 21:09
jbadger95
jbadger95 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@jbadger95 jbadger95 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overwrites a few things on merge (into next) but otherwise seems to work well

@stefanhenneking
Copy link
Contributor Author

I will squash-merge it into master and if any larger issues come up we can roll it back.

@stefanhenneking stefanhenneking merged commit 463ed4d into master Mar 17, 2023
@stefanhenneking stefanhenneking removed the ready-for-review Ready to be reviewed label Mar 18, 2023
jdmorap pushed a commit that referenced this pull request Jul 25, 2023
@stefanhenneking @jdmorap
Fortran style (#75)
d554b23 
* Removing common blocks
* Adding implicit none statements
* Adding DEBUG_MODE preprocessor flags for iprint sections
* Converting .F to .F90 standard
* Modernizing some of the Fortran language
* Adjusting Fortran style to be more consistent within hp3D
* Some code documentation (doxygen)
* Moving unused and/or obsolete files into separate folders
* Some improvements to test/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbadger95 jbadger95 jbadger95 approved these changes

Assignees

@stefanhenneking stefanhenneking

@ac1512 ac1512

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit save declaration with locally initialized variables Convert fixed-format Fortran to modern Fortran
3 participants
@stefanhenneking @jbadger95 @ac1512