Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching Themes breaks view with Slick sliders #24

Closed
a0c opened this issue Feb 23, 2015 · 1 comment
Closed

Switching Themes breaks view with Slick sliders #24

a0c opened this issue Feb 23, 2015 · 1 comment

Comments

@a0c
Copy link

a0c commented Feb 23, 2015

Since slick.css is added via Theme facility, switching to a different Theme (e.g. some black one) breaks any view which uses Slick JS library.

Multi-image should be usable regardless of the Theme selected.

Hence, css must be added to website.assets_frontend template directly.
@a0c a0c changed the title Switching to any Theme breaks Slick part Switching to any Theme breaks view with Slick sliders Feb 23, 2015
@a0c a0c changed the title Switching to any Theme breaks view with Slick sliders Switching Themes breaks view with Slick sliders Feb 23, 2015
lukebranch added a commit that referenced this issue Feb 24, 2015
@lukebranch
Merge pull request #25 from a0c/themes_break_slick_sliders
2cf59b3 
fix #24
@lukebranch
Copy link

@a0c ,

Thanks for the issue report.

moylop260 pushed a commit to vauxoo-dev/website_multi_image that referenced this issue Nov 23, 2015
@a0c @moylop260
fix OdooCommunityWidgets#24
fca805f 
- CSS is no longer attached to Theme, so other Themes can be used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukebranch @a0c