refatoring + small improvements #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebranch
added a commit
that referenced
this pull request
May 7, 2015
refatoring + small improvements
|
Thanks for the PR! I'm currently very busy with another project, and I am waiting for a stable 8.0 version of product_images (from the OCA/product-attribute repository) to be merged into the OCA. Once this has been merged i'll be rewriting a separate branch of the module to use product_images instead of the current structure to allow for more flexibility. |
|
Ok, no problem. Just keep in mind that I made some work in this module that can be helpful. |
|
Thanks, i'll definitely migrate all the improvements over along with the new features to the new branch for the module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this PR fixes issue with wrong link to ajax-loader.gif