Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media controls notification showing disambiguation drawer #212

Merged
merged 1 commit into from
May 23, 2022

Conversation

ktprograms
Copy link
Collaborator

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change

PR Type

What kind of change does this PR introduce?

  • Bugfix

Fixes

Fix: #210

What is the current behavior?

Clicking media controls notification show disambiguation drawer with LBRY and Odysee apps available.

What is the new behavior?

Directly open Odysee MainActivity when clicking media controls notification.

Other information

Use direct intent to MainActivity instead of deep link intent.

Use non-deprecated PlayerNotificationManager.Builder constructor.

Use direct intent to MainActivity instead of deep link intent.

Use non-deprecated PlayerNotificationManager.Builder constructor.

Fix: #210
@tzarebczan tzarebczan requested a review from akinwale May 19, 2022 14:05
ktprograms added a commit to ktprograms/lbry-android that referenced this pull request May 23, 2022
Use direct intent to MainActivity instead of deep link intent.

Backport of fix in OdyseeTeam/odysee-android#212
Copy link
Contributor

@akinwale akinwale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@akinwale akinwale merged commit 26767be into master May 23, 2022
@ktprograms ktprograms deleted the media-controls-notification-no-disambiguation branch May 24, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choice between Odysee and LBRY app shown when clicking media playing notification
2 participants