Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choice between Odysee and LBRY app shown when clicking media playing notification #210

Closed
10 tasks
ktprograms opened this issue May 19, 2022 · 1 comment · Fixed by #212
Closed
10 tasks

Choice between Odysee and LBRY app shown when clicking media playing notification #210

ktprograms opened this issue May 19, 2022 · 1 comment · Fixed by #212
Assignees
@ktprograms
Labels
bug Something isn't working

Comments

@ktprograms
Copy link
Collaborator

The Issue

Steps to reproduce

  1. Start playing a video
  2. Open the notifications shade
  3. Tap on the media notification

Expected behaviour

Opens currently playing media in Odysee.

Actual behaviour

Shows "Open with" popup picking between LBRY and Odysee app.

System Configuration

  • Device: Samsung Galaxy A23
  • Android version: 12

Reported by my friend

Internal Use

Acceptance Criteria

Definition of Done

  • Tested against acceptance criteria
  • Tested against the assumptions of the user story
  • The project builds without errors
  • Unit tests are written and passing
  • Tests on devices/browsers listed in the issue have passed
  • QA performed & issues resolved
  • Refactoring completed
  • Any configuration or build changes documented
  • Documentation updated
  • Peer Code Review performed
@ktprograms ktprograms added the bug Something isn't working label May 19, 2022
@ktprograms ktprograms self-assigned this May 19, 2022
ktprograms added a commit that referenced this issue May 19, 2022
@ktprograms
Fix media controls notification showing disambiguation drawer
3103b43 
Use direct intent to MainActivity instead of deep link intent.

Use non-deprecated PlayerNotificationManager.Builder constructor.

Fix: #210
@ktprograms ktprograms mentioned this issue May 19, 2022
Merged
3 tasks
@kekkyojin
Copy link
Collaborator

This was a great catch, as user would expect the same app which created the notification would be opened without OS having to ask for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktprograms ktprograms

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix media controls notification showing disambiguation drawer OdyseeTeam/odysee-android
2 participants
@kekkyojin @ktprograms