Bridge: add pausable outbox execution, inbox updating, and delayed msg enqueueing #107
+185
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
hm, so currently "inbox updating" = both batch posting and force-including; maybe we'd want to make those separately pausable? |
|
^ maybe we remove PausableUpgradable from the inbox inheritance and add an empty storage slot for _paused? |
DZGoldman
commented
Jan 12, 2024
| function _grantAllPauseRolesTo(address owner) internal { | ||
| _grantRole(DEFAULT_ADMIN_ROLE, owner); | ||
| _grantRole(PAUSE_OUTBOX_EXECUTION_ROLE, owner); | ||
| _grantRole(UNPAUSE_OUTBOX_EXECUTION_ROLE, owner); |
There was a problem hiding this comment.
thinking maybe the separate pause/unpause roles aren't necessary (and if we wanted to split up pause/unpause affordances we could do so via smart contract wallet)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pause delayed msg enqueuing role supplants the pausable inbox if we want to remove that